8000 feat(MMST): multi minimum spanning tree environment by ulricharmel · Pull Request #135 · instadeepai/jumanji · GitHub

More Web Proxy on the site http://driver.im/

feat(MMST): multi minimum spanning tree environment #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ulricharmel merged 35 commits into main from feat-cmst

Jun 2, 2023

Contributor

ulricharmel commented

•

Full implementation with docs and actor critic network.

Here is the link with the run comparing the actor-critc and the random agent for the defaults environment configs.

Close #128

ulricharmel added 9 commits

May 7, 2023 12:45


          added folder with code for cooperative minimum spanning tree

efd8cd2


          fix typo

1c88cb7


          add networkx to requirements

e46df34


          modified the observation shapes to be fully single agent

8d327ac


          entire environment with networks and docs

9eb31bf


          Merge branch 'main' into cmst-trim

5beae7d


          fixed linters

ebf4be4


          removed certain attributes from viewer

f5b3c2a


          fixed comment in viewer test

c390372

clement-bonnet changed the title ~~Feat: Cooperative minimum spanning tree environment~~ feat(CMST): cooperative minimum spanning tree environment

clement-bonnet requested changes

View reviewed changes

Collaborator

clement-bonnet left a comment

Thanks so much for your contribution! It is a difficult environment. I have left a few preliminary comments before digging deeper into the code. Please let me know if they sound reasonable.
Thanks!

jumanji/environments/routing/cmst/env.py Outdated Show resolved Hide resolved

jumanji/environments/routing/cmst/env.py Outdated Show resolved Hide resolved

jumanji/environments/routing/cmst/env.py Outdated Show resolved Hide resolved

jumanji/environments/routing/cmst/env.py Outdated Show resolved Hide resolved

jumanji/environments/routing/cmst/env.py Outdated Show resolved Hide resolved

requirements/requirements.txt Outdated Show resolved Hide resolved

jumanji/environments/routing/cmst/viewer.py Outdated Show resolved Hide resolved

jumanji/environments/routing/cmst/viewer.py Outdated Show resolved Hide resolved

jumanji/environments/routing/cmst/reward.py Outdated Show resolved Hide resolved

jumanji/environments/routing/cmst/reward.py Outdated Show resolved Hide resolved

ulricharmel added 4 commits

May 15, 2023 11:50


          renamed to cmst and address initial PR comments

2e5ed25


          added cmst config

9fd9d8c


          changed the environment name from cmst to mmst

883c33d


          updated readme files

e12401d

ulricharmel changed the title ~~feat(CMST): cooperative minimum spanning tree environment~~ feat(MMST): multi minimum spanning tree environment

ulricharmel added 2 commits

May 23, 2023 12:28


          Merge branch 'main' into feat-cmst

1f46623


          modified reward values and settings for default environment

9c5431e

ElshadaiK reviewed

View reviewed changes

jumanji/environments/routing/mmst/types.py Outdated Show resolved Hide resolved

ElshadaiK reviewed

View reviewed changes

jumanji/environments/routing/mmst/types.py Outdated Show resolved Hide resolved

ElshadaiK reviewed

View reviewed changes

jumanji/environments/routing/mmst/types.py Show resolved Hide resolved

ElshadaiK reviewed

View reviewed changes

jumanji/environments/routing/mmst/env.py Outdated Show resolved Hide resolved

ElshadaiK reviewed

View reviewed changes

jumanji/environments/routing/mmst/env.py Outdated Show resolved Hide resolved

ElshadaiK reviewed May 24, 2023

View reviewed changes

jumanji/environments/routing/mmst/env.py Show resolved Hide resolved

ElshadaiK reviewed May 24, 2023

View reviewed changes

jumanji/environments/routing/mmst/env.py Outdated Show resolved Hide resolved

ElshadaiK reviewed May 24, 2023

View reviewed changes

jumanji/environments/routing/mmst/env.py Outdated Show resolved Hide resolved

ElshadaiK reviewed May 24, 2023

View reviewed changes

jumanji/environments/routing/mmst/generator.py Outdated Show resolved Hide resolved

ElshadaiK reviewed May 24, 2023

View reviewed changes

jumanji/environments/routing/mmst/generator.py Outdated Show resolved Hide resolved

ulricharmel added 2 commits May 24, 2023 17:22

Merge branch 'main' into feat-cmst

edf2325

address PR comments and breakup some functions

d169b05

ulricharmel self-assigned this May 29, 2023

ulricharmel added 3 commits May 29, 2023 11:04

Merge branch 'main' into feat-cmst

0c4fe18

add extras to the environment

874112a

defualt configuration for paper

e4c5615

cemlyn007 self-requested a review May 6D47 31, 2023 11:20

cemlyn007 reviewed May 31, 2023

View reviewed changes

jumanji/environments/routing/mmst/env.py Outdated Show resolved Hide resolved

cemlyn007 reviewed May 31, 2023

View reviewed changes

jumanji/environments/routing/mmst/env.py Show resolved Hide resolved

cemlyn007 reviewed May 31, 2023

View reviewed changes

jumanji/environments/routing/mmst/env.py Outdated Show resolved Hide resolved

cemlyn007 reviewed May 31, 2023

View reviewed changes

jumanji/environments/routing/mmst/env.py Outdated Show resolved Hide resolved

minor refactoring from PR review

51e136f

cemlyn007 reviewed May 31, 2023

View reviewed changes

jumanji/environments/routing/mmst/env.py Outdated Show resolved Hide resolved

ulricharmel and others added 8 commits May 31, 2023 20:29

fixed comments

6c81948

fixed more comments

de1055e

sum rewards in reward function

1b18bb2

fixed issue with reward summing after move

ee8b52c

update after computing rewards

4872349

Merge branch 'main' into feat-cmst

5597b52

fixed merge conflicts

dd22f7c

Merge branch 'main' into feat-cmst

9b4abcf

clement-bonnet requested changes Jun 1, 2023

View reviewed changes

Copy link

Collaborator

clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a few inconsistencies. Would you mind fixing these before we merge?

docs/environments/mmst.md Outdated Show resolved Hide resolved

docs/environments/mmst.md Outdated Show resolved Hide resolved

jumanji/training/configs/env/cmst.yaml Outdated Show resolved Hide resolved

jumanji/training/configs/config.yaml Outdated Show resolved Hide resolved

jumanji/environments/routing/mmst/types.py Outdated Show resolved Hide resolved

jumanji/environments/routing/mmst/env.py Outdated Show resolved Hide resolved

jumanji/environments/routing/mmst/env.py Outdated Show resolved Hide resolved

jumanji/environments/routing/mmst/env.py Outdated Show resolved Hide resolved

jumanji/environments/routing/mmst/env.py Outdated Show resolved Hide resolved

jumanji/environments/routing/mmst/env.py Outdated Show resolved Hide resolved

ulricharmel and others added 6 commits June 1, 2023 18:19

Merge branch 'main' into feat-cmst

ca82077

modified generator

3217cbf

removed truncation

c5787fa

fixed few comment typos

f4a5438

fixed linting

b974b7d

Merge branch 'main' into feat-cmst

ba7d6cc

clement-bonnet approved these changes Jun 2, 2023

View reviewed changes

Copy link

Collaborator

clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

jumanji/environments/routing/mmst/utils.py Show resolved Hide resolved

ulricharmel merged commit 4edfdd5 into main Jun 2, 2023

ulricharmel deleted the feat-cmst branch June 2, 2023 18:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cemlyn007 cemlyn007 left review comments

ElshadaiK ElshadaiK left review comments

clement-bonnet clement-bonnet approved these changes

Assignees

ulricharmel

Labels

None yet

Projects

None yet

Milestone
No milestone

Development

Successfully merging this pull request may close these issues.
feat(cmst): full environment

4 participants

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms

Privacy

Security

Status

Docs

Contact

0