8000 feat(tsp): generator by surana01 · Pull Request #137 · instadeepai/jumanji · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat(tsp): generator #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 23, 2023
Merged

feat(tsp): generator #137

merged 11 commits into from
May 23, 2023

Conversation

surana01
Copy link
Contributor

Implement a Generator class for the TSP environment which is responsible for generating the TSP instances. This will include the following additions:

  • A generator.py script added to the tsp folder which implements an abstract class Generator and a RandomGenerator to create a random uniform TSP instance.
  • A generator_test.py script to test the generator.
  • Modifications to env.py to include the generator in the init method and changes to conftest.py to include a DummyGenerator for testing purposes.

@surana01 surana01 added the enhancement New feature or request label May 18, 2023
@surana01 surana01 requested a review from clement-bonnet May 18, 2023 09:12
@surana01 surana01 self-assigned this May 18, 2023
clement-bonnet
clement-bonnet previously approved these changes May 18, 2023
Copy link
Collaborator
@clement-bonnet clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution, the PR looks really good. I have approved yet left a few comments on small things. Please let me know if they make sense.

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
surana01 and others added 5 commits May 18, 2023 17:25
Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
clement-bonnet
clement-bonnet previously approved these changes May 19, 2023
Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
Copy link
Collaborator
@clement-bonnet clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@surana01 surana01 merged commit b9f1bd0 into instadeepai:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0