support xpu in tuning and inference #481
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1ck-guo
reviewed
Apr 1, 2025
|
|
||
| # Find the backend and determine the device type from BackendInfos | ||
| backend = self.find_backend(target_backend) | ||
| if backend is None: | ||
| raise ValueError("Backend not found, please set it to 'auto' to have a try ") | ||
| raise ValueError("Backend is not found, please set it to 'auto' to have a try ") |
There was a problem hiding this comment.
set it to 'auto' and try again?
There was a problem hiding this comment.
I feel that this sentence should not add 'is', Backend not found.
n1ck-guo
approved these changes
Apr 1, 2025
n1ck-guo
reviewed
Apr 1, 2025
| @@ -385,29 +392,29 @@ def detect_device(self, target_backend, orig_backend): | |||
| return "cuda" | |||
| elif "hpu" in target_backend: | |||
| return "hpu" | |||
| elif "xpu" in target_backend: | |||
| return "xpu" | |||
| elif "cpu" in target_backend: | |||
| return "cpu" | |||
There was a problem hiding this comment.
How about:
for device_type in ["cuda", "hpu", "xpu", "cpu"]:
if device_type in target_backend:
return device_type
|
merged first, all the issue will be fixed in the next pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: issue=xpu could not be automatically used when not using auto backend