8000 Enhancement: Restructure rest grpc ws servers by mahendraintelops · Pull Request #128 · intelops/compage · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enhancement: Restructure rest grpc ws servers #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 22 commits into from
Jun 18, 2023
Merged

Enhancement: Restructure rest grpc ws servers #128

merged 22 commits into from
Jun 18, 2023

Conversation

mahendraintelops
Copy link
Contributor
@mahendraintelops mahendraintelops commented Jun 12, 2023 •
edited
Loading

We can now create just clients for WS, gRPC and REST, no need to have the destination microservice be the server of these protocols.

@codecov-commenter
Copy link
codecov-commenter commented Jun 12, 2023 •
edited by codecov bot
Loading

Codecov Report

Patch coverage: 64.41% and project coverage change: +2.51 🎉

Comparison is base (6dd3bc7) 37.90% compared to head (67d380f) 40.42%.

❗ Current head 67d380f differs from pull request most recent head d35c405. Consider uploading reports for the commit d35c405 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   37.90%   40.42%   +2.51%     
==========================================
  Files          87       88       +1     
  Lines        5384     5474      +90     
  Branches       17       17              
==========================================
+ Hits         2041     2213     +172     
+ Misses       3195     3125      -70     
+ Partials      148      136      -12
Flag Coverage Δ
app 39.42% <97.91%> (+0.38%) ⬆️
core 41.10% <59.82%> (+3.97%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/src/routes/projects-operations.ts 26.22% <0.00%> (ø)
core/internal/converter/converter.go 39.68% <0.00%> (ø)
core/internal/languages/golang/models.go 100.00% <ø> (+50.00%) ⬆️
core/internal/languages/java/generator.go 0.00% <0.00%> (ø)
core/internal/languages/javascript/generator.go 0.00% <0.00%> (ø)
...ore/internal/languages/openapi-generator-runner.go 0.00% <0.00%> (ø)
core/internal/languages/python/generator.go 0.00% <0.00%> (ø)
core/internal/languages/python/models.go 0.00% <ø> (ø)
core/internal/languages/ruby/generator.go 0.00% <0.00%> (ø)
core/internal/languages/rust/generator.go 0.00% <0.00%> (ø)
... and 9 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mahendraintelops mahendraintelops force-pushed the restructure-rest-grpc-ws-servers branch from 6ecc0e7 to bb77517 Compare June 12, 2023 12:47
@mahendraintelops mahendraintelops force-pushed the restructure-rest-grpc-ws-servers branch from bb2ecd1 to d2c0595 Compare June 13, 2023 08:47
@mahendraintelops mahendraintelops force-pushed the restructure-rest-grpc-ws-servers branch from d2c0595 to 549915f Compare June 13, 2023 08:51
@mahendraintelops mahendraintelops force-pushed the restructure-rest-grpc-ws-servers branch from 6ae8f89 to 5061149 Compare June 16, 2023 07:37
@mahendraintelops mahendraintelops force-pushed the restructure-rest-grpc-ws-servers branch from fef13d1 to 525591a Compare June 18, 2023 07:34
@mahendraintelops mahendraintelops force-pushed the restructure-rest-grpc-ws-servers branch from 67d380f to d35c405 Compare June 18, 2023 09:43
@mahendraintelops mahendraintelops merged commit 783b811 into main Jun 18, 2023
@mahendraintelops mahendraintelops deleted the restructure-rest-grpc-ws-servers branch July 12, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahendraintelops @codecov-commenter
0