8000 Adjusted alternate version to preserve formatting by uguu-org · Pull Request #145 · ioccc-src/winner · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Adjusted alternate version to preserve formatting #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 16, 2025

Conversation

uguu-org
Copy link
Contributor

The first alt version added some whitespaces that broke the outline, so I simply filled those up. I also expanded tabs to spaces since there is no size limit restriction for the alternate version.

The second alt version attempted to force binary mode with _setmode() and _fileno() calls, plus some additional headers. Rather than doing it this way, I hack in the binary mode adjustments via preprocessor.

Actually I did a similar trick for IOCCC 2011, but I guess I didn't submit that version:
https://uguu.org/archive/ioccc2011/akari/source/binmode_main.h

The file above uses _setmode() and _fileno(). The leading underscore indicates that they were nonstandard extensions. For the binmode_main.h in this change, I have opted for setmode() and STDIN_FILENO instead, which are more widely available.

uguu-org added 3 commits May 15, 2025 17:51
The first alt version added some whitespaces that broke the outline, so
I simply filled those up.  I also expanded tabs to spaces since there is
no size limit restriction for the alternate version.

The second alt version attempted to force binary mode with _setmode()
and _fileno() calls, plus some additional headers.  Rather than doing it
this way, I hack in the binary mode adjustments via preprocessor.

Actually I did a similar trick for IOCCC 2011, but I guess I didn't
submit that version:
https://uguu.org/archive/ioccc2011/akari/source/binmode_main.h

The file above uses _setmode() and _fileno().  The leading underscore
indicates that they were nonstandard extensions.  For the binmode_main.h
in this change, I have opted for setmode() and STDIN_FILENO instead,
which are more widely available.
Copy link
Contributor
@lcn2 lcn2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lcn2
Copy link
Contributor
lcn2 commented May 16, 2025

We will accept this PR and then perform the additional processing in a later commit. Thank you @uguu-org

UPDATE 0

Completed your PR, @uguu-org with commit 51f4d86.

Thanks!

@lcn2 lcn2 merged commit 457d631 into ioccc-src:master May 16, 2025
1 check passed
lcn2 added a commit that referenced this pull request May 16, 2025
The tarballs were updated.

Removed reference to the previous mod from `thanks-for-help.md`.

Updated the `2012/omoikane/index.html` page.

Updated sitemap.
@xexyl
Copy link
Contributor
xexyl commented May 16, 2025

We will accept this PR and then perform the additional processing in a later commit. Thank you @uguu-org

UPDATE 0

Completed your PR, @uguu-org with commit 51f4d86.

Thanks!

First of all thanks to @uguu-org.

Second of all please remove the alt code from the thanks file as it seems like what I did no longer stands. If I didn't do anything else there then by all means remove that item entirely. I don't have the time to do it myself.

Thanks.

No I did not look if this was already done but just in case.

@uguu-org
Copy link
Contributor Author

@xexyl Your alt code removed a dependency on /dev/urandom, so I thought it was worth keeping around for that.

Thanks for your effort in fixing the entries :)

@xexyl
Copy link
Contributor
xexyl commented May 16, 2025

@xexyl Your alt code removed a dependency on /dev/urandom, so I thought it was worth keeping around for that.

Ah. That was for macOS - it doesn't have /dev/urandom (unfortunately). So if you removed that that could be an issue. Don't have the time to check I'm afraid (I did not even look at the log here - I just noticed you changed the alt code.)

Thanks for your effort in fixing the entries :)

I'm glad you appreciated it! Means a lot - more than you might know. It was a lot of fun and also educational.

Best wishes!

lcn2 added a commit that referenced this pull request May 18, 2025
The tarballs were updated.

Removed reference to the previous mod from `thanks-for-help.md`.

Updated the `2012/omoikane/index.html` page.

Updated sitemap.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0