8000 Use SwiftLint only during the development phase. by gmlwhdtjd · Pull Request #285 · ioskrew/SwiftLayout · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Use SwiftLint only during the development phase. #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

gmlwhdtjd
Copy link
Contributor

Adopting SwiftLint as a dependency introduces eight additional packages, including swift-syntax, which are unnecessary for SwiftLayout users. The swift-syntax package, in particular, could cause build failures depending on how Swift macros are applied.

To resolve this, I propose modifying the setup to use SwiftLint only during development by enabling it with a flag.

However, since I couldn’t find a way to automatically detect the development environment, this solution is currently implemented as a local value.

@gmlwhdtjd gmlwhdtjd requested a review from oozoofrog August 9, 2024 01:08
@gmlwhdtjd gmlwhdtjd self-assigned this Aug 9, 2024
Copy link
Collaborator
@oozoofrog oozoofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@gmlwhdtjd gmlwhdtjd merged commit 1a986f1 into develop Aug 9, 2024
1 check passed
@gmlwhdtjd gmlwhdtjd deleted the use-swiftlint-during-develop branch August 9, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0