fix: support --flush=false in files rm
#10848
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
commented
Jun 24, 2025
Comment on lines
-1339
to
-1344
| err = pdir.Unlink(name) | ||
| if err != nil { | ||
| return err | ||
| if err := pdir.Unlink(name); err != nil { | ||
| return err | ||
| } | ||
| } | ||
|
|
||
| return pdir.Flush() |
There was a problem hiding this comment.
cc @gammazero @hsanjuan For a sanity check: Do you know if always flushing the parent of the removed item here, while ignoring --flush=false, was a bug or a conscious design decision?
As this PR stands now, I've "fixed" it by adding support for --flush=false, which allows users to skip flushing the parent of the removed item.
Let me know if you have any concerns about this.
This was referenced Jun 24, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to close #10842:
--flush=falseto--helptext inipfs filescommands that support itipfs files rmignored--flush=falseand always flushed the parent