chore: 8000 Upgrade github.com/cockroachdb/pebble/v2 to v2.0.6 for Go 1.25 support #10850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 tasks
Go 1.25 incompatibility detected in * Homebrew/homebrew-core#226636 then: * reported upstream in cockroachdb/swiss#48 * fixed upstream cockroachdb/swiss#49 This PR brings this fix upstream to kubo. The fix was brought to github.com/cockroachdb/pebble/v2 in * cockroachdb/pebble#4954 And released in https://github.com/cockroachdb/pebble/releases/tag/v2.0.6 Which is now used. Full changelog: cockroachdb/pebble@v2.0.3...v2.0.6
stefanb
added a commit
to stefanb/ipget
that referenced
this pull request
Jun 29, 2025
Go 1.25 incompatibility detected in * Homebrew/homebrew-core#226636 then: * reported upstream in cockroachdb/swiss#48 * fixed upstream cockroachdb/swiss#49 This PR brings just this upstream fix upstream to ipfs. Alternatively we could wait until * ipfs/kubo#10850 is merged and released an then upgrade the `github.com/ipfs/kubo` direct dependancy. --- Before: go1.25rc1 build ./... github.com/cockroachdb/swiss # github.com/cockroachdb/swiss ../../../go/pkg/mod/github.com/cockroachdb/swiss@v0.0.0-20250327203710-2932b022f6df/map.go:286:7: undefined: hashFn ../../../go/pkg/mod/github.com/cockroachdb/swiss@v0.0.0-20250327203710-2932b022f6df/map.go:337:14: undefined: getRuntimeHasher ../../../go/pkg/mod/github.com/cockroachdb/swiss@v0.0.0-20250327203710-2932b022f6df/map.go:338:22: undefined: fastrand64 ../../../go/pkg/mod/github.com/cockroachdb/swiss@v0.0.0-20250327203710-2932b022f6df/map.go:600:23: undefined: fastrand64 ../../../go/pkg/mod/github.com/cockroachdb/swiss@v0.0.0-20250327203710-2932b022f6df/map.go:649:19: undefined: fastrand64 ../../../go/pkg/mod/github.com/cockroachdb/swiss@v0.0.0-20250327203710-2932b022f6df/map.go:670:20: undefined: fastrand64 ../../../go/pkg/mod/github.com/cockroachdb/swiss@v0.0.0-20250327203710-2932b022f6df/options.go:30:14: undefined: hashFn Upgrade: go get -u github.com/cockroachdb/swiss && go mod tidy go: upgraded github.com/cockroachdb/swiss v0.0.0-20250327203710-2932b022f6df => v0.0.0-20250624142022-d6e517c1d961 After: go1.25rc1 build ./... (build successful)
|
I think this one would be bubbled by updating go-ds-pebble |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.25 incompatibility detected in
then:
The fix was brought to github.com/cockroachdb/pebble/v2 in
And released in https://github.com/cockroachdb/pebble/releases/tag/v2.0.6
Which is now used in this PR.
Full changelog: cockroachdb/pebble@v2.0.3...v2.0.6