8000 fix: republish function to handle key and value generation by shobit000 · Pull Request #753 · ipfs/helia · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: republish function to handle key and value generation #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

fix: republish function to handle key and value generation #753

wants to merge 4 commits into from

Conversation

shobit000
Copy link

Title

Fix republish function to handle key and value generation

Description

This pull request addresses issue #750 by updating the republish function to properly handle key and value generation. The following changes were made:

  • Added key generation using generateKeyPair.
  • Integrated value retrieval using unixfs.addBytes.
  • Updated the republish function to incorporate these changes.

Changes Made

  • Added generateKeyPair to generate a new key pair.
  • Used unixfs.addBytes to retrieve the value to be published.
  • Updated the logic to handle sequence numbers and record creation.

Related Issue

Closes #750

How Has This Been Tested?

  • Verified key and value generation locally.
  • Ensured the republish function works without errors.
  • Validated the changes do not break existing functionality.

Additional Comments

Please review the changes and provide feedback. Thank you!

@shobit000 shobit000 requested a review from a team as a code owner March 3, 2025 17:37
achingbrain
achingbrain requested changes Mar 6, 2025
View reviewed changes
Copy link
Member
@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change periodically publishes junk data using a random key.

It does not address #750.

@achingbrain
Copy link
Member
achingbrain commented Mar 11, 2025 •
edited
Loading

Closing as this does not fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain achingbrain requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: implement republish method
2 participants
@shobit000 @achingbrain
0