Fixed issue with overflow on 32bit OS. #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed overflow at line 508 in deets.rs for 32bit OS. Fixed rustc compiler warning in macros.rs for spurious semi-colon. Minor refactoring on structs to use shorthand.
Fixed issue with overflow on 32bit OS.
Changed formatting for display to show 2 decimal places. Corrected logic for display if the total value is less than 1GiB.
|
Hey @Xiderpunk can you trim it down to just the 32bit overflow stuff? That ways its not a code thing. |
|
Absolutely, will do that this evening I hope. Will just make it granular. Also yes I see, and yeah would make sense to place the degree symbol into the config. |
iphands
added a commit
that referenced
this pull request
Sep 29, 2022
Bringing over helpful changes from #28 Co-authored-by: Chris Norris <Xiderpunk@users.noreply.github.com>
|
Manually merged, added as co-author. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deets.rs was causing a panic on overflow for: statvfs.f_bsize * statvfs.f_bfree. I just rejigged a bit to prevent overflow when they are multiplied.
Fixed a compiler warning on macros.rs for a spurious semi-colon for future proofing.
Minor refactoring on some elements of structs to shorthand, just for readability.