8000 Fix issues found by SonarCloud by alexrster · Pull Request #7 · ipphone/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix issues found by SonarCloud #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 20, 2018
Merged

Fix issues found by SonarCloud #7

merged 7 commits into from
Dec 20, 2018

Conversation

alexrster
Copy link
Contributor

Remove unnecessary locks

Copy link
Contributor Author
@alexrster alexrster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 1
Code Smell Code Smells: 32

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: The event 'SIP.RecordingDeviceChanged' is never used (more)
  2. Code Smell Code Smell: The event 'SIP.PlaybackDeviceChanged' is never used (more)

See all issues in SonarCloud

Copy link
Contributor Author
@alexrster alexrster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 1
Code Smell Code Smells: 32

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: The event 'SIP.RecordingDeviceChanged' is never used (more)
  2. Code Smell Code Smell: The event 'SIP.PlaybackDeviceChanged' is never used (more)

See all issues in SonarCloud

Copy link
Contributor Author
@alexrster alexrster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 1
Code Smell Code Smells: 13

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: The event 'SIP.RecordingDeviceChanged' is never used (more)
  2. Code Smell Code Smell: The event 'SIP.PlaybackDeviceChanged' is never used (more)

See all issues in SonarCloud

Copy link
Contributor Author
@alexrster alexrster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 9

Including the following issue(s) which could not be reported in line:

  1. Code Smell Code Smell: The variable 'watcherTimer' is declared but never used (more)

See all issues in SonarCloud

@alexrster alexrster merged commit 604cf9f into master Dec 20, 2018
@alexrster alexrster deleted the ay-codeanalysis-fix branch December 20, 2018 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0