10000 update the spawn point avatar random placement logic by MbfloydIR · Pull Request #1908 · ir-engine/ir-engine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update the spawn point avatar random placement logic #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 5, 2025
Merged

update the spawn point avatar random placement logic #1908

merged 8 commits into from
Jun 5, 2025

Conversation

MbfloydIR
Copy link
Contributor

Summary

https://tsu.atlassian.net/browse/IR-9412

Subtasks Checklist

Breaking Changes

References

closes #insert number here

QA Steps

@MbfloydIR MbfloydIR marked this pull request as ready for review May 16, 2025 20:35
@MbfloydIR MbfloydIR requested a review from AidanCaruso as a code owner May 16, 2025 20:35
kattsushi
kattsushi approved these changes May 29, 2025
View reviewed changes
packages/engine/src/avatar/functions/getSpawnPoint.ts Outdated
const radius = 0.5
const x = (Math.random() - 0.5) * 2 * radius + area.x
const z = (Math.random() - 0.5) * 2 * radius + area.z
console.log('mbf', area)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just remove the logs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

implemented

LGTM just remove the logs

HexaField
HexaField requested changes May 30, 2025
View reviewed changes
Copy link
Member
@HexaField HexaField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to use the scale of the spawn point entity in order to decide the radius, otherwise we can't change the size of the spawn area

SYBIOTE
SYBIOTE previously requested changes May 30, 2025
View reviewed changes
Copy link
Contributor
@SYBIOTE SYBIOTE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Connect radius to scale, for increasing spawn size, im assuming spawn points are cylindrical now

@HexaField
Copy link
Member

Connect radius to scale, for increasing spawn size, im assuming spawn points are cylindrical now

they're not, we don't have a specification for that. really it should be labelled size not radius

@MbfloydIR
Copy link
Contributor Author
MbfloydIR commented Jun 4, 2025 •
edited
Loading

we need to use the scale of the spawn point entity in order to decide the radius, otherwise we can't change the size of the spawn area

implemented

HexaField
HexaField previously requested changes Jun 5, 2025
View reviewed changes
@MbfloydIR MbfloydIR enabled auto-merge June 5, 2025 21:39
@MbfloydIR MbfloydIR dismissed stale reviews from HexaField and SYBIOTE June 5, 2025 21:40

changes implemented

@MbfloydIR MbfloydIR added this pull request to the merge queue Jun 5, 2025
Merged via the queue into dev with commit 2ff2443 Jun 5, 2025
24 checks passed
@MbfloydIR MbfloydIR deleted the michael/IR-9412_spawnpoint branch June 5, 2025 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tortillaguy Tortillaguy Tortillaguy approved these changes

@kattsushi kattsushi kattsushi approved these changes

@jose-galvan jose-galvan jose-galvan approved these changes

@HexaField HexaField HexaField left review comments

@SYBIOTE SYBIOTE SYBIOTE left review comments

@AidanCaruso AidanCaruso Awaiting requested review from AidanCaruso AidanCaruso is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MbfloydIR @HexaField @Tortillaguy @kattsushi @jose-galvan @SYBIOTE @svyoung
0