Remove NameComponent.getEntitiesByName #1946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor AvatarIKComponents and NameComponent to use UUID for entity identification
…me-with-safer-mechanism-for-getting-and-entity
…me-with-safer-mechanism-for-getting-and-entity
…me-with-safer-mechanism-for-getting-and-entity
speigg
approved these changes
May 27, 2025
larryatinfinite
added a commit
that referenced
this pull request
May 29, 2025
* IR-9127 Record reported user's IP address when creating a report (#1826) * Record reported user's IP address when creating a report * refactor --------- Co-authored-by: Hanzla Mateen <hanzlamateen@live.com> * Fix zIndex value for loading view in LocationRoutes component (#1812) * [IR-9187] Add grouping for file name upload errors (#1811) * Stop animations when "None" is selected or component is removed (#1733) * Stop animations when "None" is selected or component is removed * Loop animation tests * Remove comments --------- Co-authored-by: Michael Estes <michael@etherealengine.com> * Deep nested deltas (#1628) * wip * fix something * wip * uuid, source to array & deltas as concatenated map of node sources * remove logs * uuid as instance, id pair * wip * undo/redo snapshots work * fix add media node and editor services * use uuid pairs for avatar spawn * avatar network related uuid updates * refactor material library ui * remove logs * animations work again * Avatar movement networking, network uuid sourced from parent * require instance id specification * refactor material uuid handling, load by entity array * etc * deltas work again, fix node id create * clean up console logs * concatenate uuids in visualscript, client-core * fix ecs serializer * getuuid takes an entity, more fixes * fixes for the fixes * unify delta commands * material deltas stuff * no logs * fix material drag drop * fix more errors * fix many things, refactor avatar transparency, fix gltf export * fix errors and avatar spawn system test * fix more tests and animation component node lookup * fix move avatar tests * more test fixes * gltf export tests pass * gltf loader test passes * fix gltfstate test * gltf loader tests pass * grabbable tests pass * mixer component test works * mount point component test passes * prefab and material library tests pass * wip * wip * wip fixes * fix retargeting functions * refactor getinstanceid and surrounding useages * fix use source id hook * begin migrating node id functions, editor tests passing * test fixes, use uuids in favor of node ids, etc. * No more node functions * more tests pass * ditto * more tests pass * ecs tests pass * no more node id generate * fix type errors * fix avatar spawn system tests * fixes * more fixes * fixes * more fixes * more fixes * fix type errors * physics tests pass * more fixes * more fixes * another fix * no more NodesBySourceState * more fixes * fix various uuid errors * errors in engine package * fix more tests * fix engine tests * more fixes * more tests * editor fixes * fix: update state retrieval in SourceComponent to use getMutableState * fix transform and material previewer * fix scene exporter * no more source component in gltf export * remove redundant uuid set * add docs, cleanup, remove extra whitespace in license header * add getAvatarAsSourceID method to AvatarComponent * clean up APIs * refactor LoopAnimationComponent tests to use structured entity identifiers * update method name * add some method docs for UUIDComponent * fix variant and spline --------- 8000 Co-authored-by: HexaField <joshfield999@gmail.com> * Resave core scenes, enable saving without modifications (#1813) resave core scenes Co-authored-by: Rahul Ghosh <ghoshr698@gmail.com> * add all dist to vscode search ignore (#1836) Co-authored-by: Rahul Ghosh <ghoshr698@gmail.com> * [MT-STG, UAT] - Compress on Publish error "object null is not iterable" (#1668) * video-image-transform * wip - ktx2 uploads now going through without error for unsupported file type, but still not uploading lod files. might have something to do with removed folder creation code * folder and gltf are being created but the LOD variants are not...progress * now properly uploads LOD files to the same location as the source * moving optional path creation to handle glb as well, need to track down what is wrong with glb compression * ch-br * removing redundant code * compress-scene * dev-pull * let-var-lint * udpd-url * revert-changes * revert * revert-2 * url-bug * editorstate-update-for-compressed-scene * local-to-hookstate * upd --------- Co-authored-by: Sam Mazer <sam.mazer@theinfinitereality.com> Co-authored-by: Sam Mazer <162159423+SamMazerIR@users.noreply.github.com> Co-authored-by: Rahul Ghosh <ghoshr698@gmail.com> * Remove accidental commit of deltas to apartment * Stop Wheel Event Propogation (#1841) * stop propogation * fix typo * some editor bug fixes (#1844) * some editor bug fixes * fix exporting animations that shouldn't be exported * remove logs --------- Co-authored-by: lonedevr <102248647+AidanCaruso@users.noreply.github.com> * [IR-9857] remove blur background to reduce draw calls and triangles (#1851) remove blur background to reduce draw calls and triangles * Add test scene fix particles and node options (#1845) * add test scene, fix particles and node options * license * resave test scene --------- Co-authored-by: lonedevr <102248647+AidanCaruso@users.noreply.github.com> * Merge scene deltas and authoring operations (#1846) * Merge scene deltas and authoring operations * license * use json ID for snapshots and ensure entity tree serialization works * update TransformComponent.jsonID to 'IR_transform' * fix tests * bug fix for duplicated entities having incorrect child index * Merge SourceComponent and NodeIDComponent into UUIDComponent (#1847) * remove SourceComponent * remove NodeIDComponent * fixes * Refactor GLTF export extensions to use overrideExporterExtension * bug fix * fix undoing overrides * Refactor UUIDComponent usage to streamline source ID handling across multiple components * editor fix * fix * Refactor UUIDComponent usage to improve source ID retrieval in avatar and scene systems * editor test dixes * revert tsconfig * Fix entity reference in EnvMapBakeReactor for correct source entity retrieval * critical bug fix related to duplicate actions * [IR-9199] Fix Viewport empty state styling (#1828) * IR-9309 Implement new UI/UX for allowing users to copy an iframe embed code of one of their published spaces (#1848) * Implement new UI/UX for allowing users to copy an iframe embed code of one of their published spaces * Refactor embed code labels for consistency across components * Enhance MoreOptionsMenu styling for better overflow handling and rounded corners * Fix typo in embed code copied message in common.json * Update MoreOptionsMenu button styling to include rounded corners --------- Co-authored-by: MoizAdnan <moizadnan21@gmail.com> * IR-9397 Migrate client setting to engine setting (#1821) * Migrate client-setting to engine-setting * remove client setting scopes from db * remove unsed getClientSetting file as now we use getEngineSettings * code refactor * remove themeModes FROM user-setting hook as themeModes is removed from settings * useMemo for performance optimization & code refactor * code refactor , add hook for engine setting and remove duplicated code for fetching engine settings * add type for MediaSettingsType since its removed with client-setting schema * use MediSettingType * refactor: update client setting key to use EngineSettings constant and modify categories to unflatten * Removed key8thWall --------- Co-authored-by: Hanzla Mateen <hanzlamateen@live.com> * IR-9167 wizard rendering (#1855) * wip storing work so far * llm stuff 1 * adding error handling in intializeSpatialViewer * removing extra state that is unused now * Prevent SceneObjectSystem reactor errors (#1857) add check to modelentityreactor * Fix UUID serialization (#1862) * Enhance UUID handling and improve GLTF extension structure * fix uuid test * fix tests * remove redundant code * fix more refs to EntityIDs as an extension * IR-6988: fix spline helper (#1853) * wip - move helper component to spline component * moves spline helper logic into SplineComponent and deletes SplineHelperComponent --------- Co-authored-by: quaiquai-ir <matthew.mcquaigue@infinitereality.com> * IR-8954: Thumbnail generation causes massive re renders and flashes (#1859) * IR-8954: re-add M. Floyd's fix * remove console.logs * temp fix re-export new engine-setting also as client-setting (#1866) * temp fix re-export new engine-setting also as client-setting * remove blank line * Apply changes from IR-5334-remake-again branch * Revert "Apply changes from IR-5334-remake-again branch" This reverts commit ea1ff4f. * Backport Rel1.0.2 to Dev (#1824) * Fixed prd suffix * Fixed prd suffix * Fixed prd suffix * hoist AssetsQueryProvider * update currentFilesProvider * IR-8500 HOTFIX 1.0.2 input stuck when losing focus (#1614) adding a listener that will clear inputs when the tab loses focus (preventing keys getting stuck as active when losing focus) * IR-8398 filetype errors hotfix 1.0.2 (#1615) cherry picking fixes to release 1.0.2 for error messages regarding file types * added mute/unmute toggle button to the video media controls (#1619) * added mute/unmute toggle button to the video media controls * fixed spelling * fixed error in method call * fixed issue with the scene thumbnail erroring, since the url string i… (#1617) fixed issue with the scene thumbnail erroring, since the url string is not always full url * Michael/ir 8380 wording 1.02 (#1581) * updated text to new verbage * updated terminology, Console -> Dashboard, Scenes/Locations -> Spaces * Updated capitalization in display text * updated the user json for the published space display text * updated terminology * reverted refs back to scenes * New wording added for the UI text files. * fixed user json --------- Co-authored-by: Armando Salazar <armando.salazar@theinfinitereality.com> * IR-8904(fix): make blue locked icon to improve ux * [HOTFIX 1.0.2] IR-8493: limit follow camera's horizontal rotation range (#1566) * feat: limit follow camera's horizontal rotation range * chore: added unit tests * Set correct colors for selected assets in light theme (#1532) change selected asset colors * Update toolbar buttons to tertiary variant (#1533) * Fixed bug with Scene Save As [release1.0.2] (#1560) Fixed bug with Scene Save As Save As doesn't pass a sceneFile with `.gltf` on the end. This does get properly cleaned and appended in the generation of `sceneName`, but that wasn't being used when generating the new gltfFile - it was still using sceneFile for some reason. Resolves IRCS-57 * [HOTFIX 1.0.2] [IR 7791] Port camera collision PR from dev (#1569) Camera collision PR port from dev * Avoid hideModal when dropdown is clicked (#1578) * Fetch joystick images from `config.client.clientURL` (#1579) Fetch joystick images from `studio.ir.world` * [HOTFIX 1.0.2] IR-8778: add transform component to media node (#1580) fix: add transform component to media node * [IR-8914] Add Documentation link to Files menu (#1634) * [IR-8919] Keep component header at top of Properties panel while scroll (#1635) IR-8919: Keep component header at top of Properties panel while scroll * [IR-8919] Add Info icon linking to component docs (#1636) * 1.02 Add additional "fit" options to the image component (similar to video component) (#1626) * wip image scale / fit * updated the editor text for the image editor node for fit and aspect ratio fixed issue with the scaling * cleaned up the resize method * [HOTFIX 1.0.2] IR-7895: filter out invalid target options for interactable component (#1612) fix: filter out invalid target options for interactable component * Texture Filtering on tileable meshes shows grey grid based on Camera Distance (#1592) * generateMipmaps true * texture anisotropy * update * test-cleanup * clean-up * helper-function-for-anisotropy * module-level-var * update variable name to maxAnisotropySupported * getMaxAnisotropy * remove-generatemipmaps * release1.0.2: (fix) Cannot drag/reorder entities in hierarchy (#1509) * feedbacks-and-design * theme-based * rm-before * theme * moving logic block back * change ref target * colors * remove twmerge * sub-function * fixes * check-entity-reorder * indent --------- Co-authored-by: Sam Mazer <sam.mazer@theinfinitereality.com> Co-authored-by: aditya-mitra <55396651+aditya-mitra@users.noreply.github.com> * fix(IR-8763): ensure scene file extension consistency - Add validation to guarantee .gltf extension in scene names - Fix potential duplicate extension issue in scene saving - Improve scene name handling in saveSceneGLTF function * remove .scene.json format check * prevent needing second click in panel * Adding descriptions for entities and components - UI language revamp (#1693) * Added missing descriptions to entities and improved content on existing labels * Improves the description of components on the properties. * Added the missing component descriptions that display when adding a new component to an entity on the hierarchy. * Fixes label references and adds one to an empty entity. * Last grammar fix and wording improvement for better usability. * Added a preposition for the empty entity label. * fixed Thumbnail generation causes massive re renders and flashes (#1667) * aded debounce refs and methods to prevent the loading ui from flickering when uploading / thumbnail generating a large amount of files increased the debounce duration to 1 sec * removed dev logs * implemented a return to clear the timeout * moved the logic for checking the thumbnail loading into its own file * Support for GIFs to be displayed in the image component (#1691) * before-pll * ch-br * b-pull * clean-up * clean-up * update * disallow * ffmpeg timeout * release1.0.2: replace studio icons with the corresponding figma icons (#1515) * replace studio icons with the corresponding figma icons * correct light mode icon * Michael/ir 3888 tag name (#1662) fixed issue with tags accepting " " * Video visible / invisible callbacks missing (#1613) * set the ObjectComponent on the auth layer when creating the mesh for a video, so its setVisible, setInvisible callbacks will be accessible for triggers * updated the ObjectComponent ti use the mesh object, instead of an empty Object 3d * rework and fix other bug --------- Co-authored-by: Daniel Belmes <danielbelmes@ymail.com> * [Release 1.0.2] IR-7891: Improve url error handling in GLTFComponent (#1637) * feat: Improve url error handling in GLTFComponent * chore: remove call to addError in GLTF component when URL is empty * chore: clean up LOADING_ERROR in GLTFComponent when URL changes * Add clear button to StringInput and SearchBar components (#1704) * fixed issue with the logic for the property editor useExecute to work… (#1706) fixed issue with the logic for the property editor useExecute to work with just the component's json if for serialization instead of the entire component definition * Update buttons in file panel to tertiary variant (#1738) * Video Component - Previews produce multiple layers of audio (#1753) muted-preview-video * [hotfix 1.0.2] Wizard: Valid format Image/logo is not displayed after uploading invalid format file first (#1754) update-file-types * Fix joystick bug in iPad Pro (#1750) Classify iPads as mobiles * Add X icon to files panel search (#1749) * Fix Loading Spinner Rel1.0.2 (#1739) * spinner * spinner * authoring-counter-part-loading * update * ring * remove-circle * positioning * debug * remove-root-ent * Revert "Fix Loading Spinner Rel1.0.2" (#1779) Revert "Fix Loading Spinner Rel1.0.2 (#1739)" This reverts commit 844f2a4. * hotfix(release1.0.2): prevent modal from being closed on click outside (#1514) * hotfix(release1.0.2): prevent modal from being closed on click outside * do not allow to hide addscene on outside modal click * Fix studio and modal images (#1775) update locations to not be in /public as vite won't build those into src * Fix Loading Spinner Rel1.0.2 (#1782) * spinner * spinner * authoring-counter-part-loading * update * ring * remove-circle * positioning * debug * remove-root-ent * [HOTFIX 1.0.2] IR-9441: fixed scroll in materials properties panel (#1795) fix: fixed scroll in materials properties panel * IR-9089 IR-7683 IR-2979 IR-7672 cherrypick release 1.0.2 (#1745) * cherry pick IR-7672 and IR-7683 * Cherry pick IR-9089 to release 1.0.2 * resolving import issues from merge * Add gif to image loader (#1794) * updt * ch-br * refresh-files-after-gif * revert-icon-npm * remove-test-title * format * fix errors * fix test from schema changes * Fix dev merge * fixing bad merge from before on GLTFComponent * media fixes * bringing back non-serialized to one of the VideoComponent fields * fix for video playback * fixing merge issue --------- Co-authored-by: Kyle Baran <kbaran@bitscoop.com> Co-authored-by: Adrian <agcacho22@gmail.com> Co-authored-by: Sam Mazer <162159423+SamMazerIR@users.noreply.github.com> Co-authored-by: MbfloydIR <144718558+MbfloydIR@users.noreply.github.com> Co-authored-by: Armando Salazar <armando.salazar@theinfinitereality.com> Co-authored-by: Andres Jimenez <andresdavid@outlook.com> Co-authored-by: José Galván <33644205+jose-galvan@users.noreply.github.com> Co-authored-by: Appaji <52322531+CITIZENDOT@users.noreply.github.com> Co-authored-by: Michael Estes <michael@etherealengine.com> Co-authored-by: Chris Dolphin <dolphin@likethemammal.com> Co-authored-by: hizir aslan <35542226+hzraslan@users.noreply.github.com> Co-authored-by: Sam Mazer <sam.mazer@theinfinitereality.com> Co-authored-by: aditya-mitra <55396651+aditya-mitra@users.noreply.github.com> Co-authored-by: Andres <asulbaran@theinfinitereality.com> Co-authored-by: Armando Salazar <121046819+armando-salazar@users.noreply.github.com> Co-authored-by: hzraslan <hzraslan@gmail.com> * [IR-6500] Handle component serialization and deserialization to be objects instead of primitive values to be GLTF compliant (#1834) * Wrap primitive components in object for GLTF extension * Serialize primitive components as objects * Error * Test * Inline GLTF spec serialization handling * missed * Remove visible component value * Test * Test * fix(IR-9478): auto-close model compression panel on completion with error handling (#1872) * Update license year (#1837) * update license year * update license year * update more licenses * fix prefabs not persisting in authoring layer (#1880) * fix prefabs not persisting in authoring layer * revert deserialize transform * [IR-9970] Add collapsible overflow menu to Viewport toolbar (#1850) * Annotate enums in component schemas (#1875) Annotated every enum represented in a schema, indicating what type of enum values are acceptable. * IR-9465: Get Engine commit from image published to GCP Artifact registry (#1881) * chore: GCP Artifact registry regex * chore: update gcpArtifactRegistryTagRegex * IR-9806: fixed missing gltf file extension to save scene with new name (#1856) fix: missing gltf file extension to save scene with new name * IR-8209: fixed files & folders search (#1852) fix: fixed files & folders search * [IR-10080] World Builder Frontend UI Hotfix #1887, org repo (#1890) [IR-10080] World Builder Frontend UI Hotfix Co-authored-by: Junhua Chang <junhua.chang@theinfinitereality.com> * add return value for duplicatedObject for builder (#1889) * IR 10059 squash redundant json patch operations upon scene save (#1879) * feat: add operation squashing utility to optimize redundant operations * move to new file * add squash to getAllCommands for scene save * fix text overflow on assets filebrowser (#1787) * fix text overflow on assets filebrowser * cleanup * use `w-24` instead * IR-8954: Thumbnail generation causes massive re renders and flashes (2) - removing dimension loading (#1884) * IR-8954: remove/commented out dimensions loading bar to reduce extra renders * added notes * [IR-9935] Model collider not generating causes model to not load (#1893) * useApplyCollidersToChildMeshesEffect changes from release hotfix * Don't remove collider twice on unmount * Remove SonarQube workflow actions due to AWS blocking current github runners (#1840) remove sonarQube * [MT-DEV] Video - media controls are not present in locations (#1894) removed the un needed for loops that setup / tear down the media components xrui controls, since they are already being handled via the MediaXRUIReactor * Michael/ir 9007 open in wizard dev (#1861) remade changes to the dev branch * IR-9376: Update KTX2 placeholder image with iR image * IR-9376: Add ktx2 version of the iR png image * Polish/Improve - Compress on Publish workflow (#1883) * ch * bf-pull * updt * compress-remove-combinedMesh * update * remove-log * IR-8740 unit tests gltf loading samplers (#1885) * wip - investigating basic properties * keep for reference * split between indirect and direct sampler testing. direct should fail as we dont follow specification for root level samplers * added mock gltf and image loader for testing our implementation * fix possible undefined variables --------- Co-authored-by: quaiquai-ir <matthew.mcquaigue@infinitereality.com> * fix(IR-8127): prevent user avatars from overflowing in viewer (#1896) * IR-9311: Add scene duplication/copy (#1878) * feat: add scene cloning functionality and update file browser schema for unique name handling * refactor: comment out unique name handling logic in folder move operation * refactor: remove unique name handling from file browser update schema and service * refactor: remove unique flag from cloneScene function parameters * refactor: rename duplicate scene labels to clone scene in editor * fix(prefab): load the new exported prefab [IR-9728] (#1864) * fix(prefab): add missing i18 words and a loading state * fix(prefab): dont allow user to close tab when click outside of the modal * fix(uuid-component): valudate null values declared in react hooks * feat(prebab): display notification when succesfully exported the prefab * fix(uuid-component): validate null in the join method * fix(uuid-component): restore validations * fix(uuid-component): validate that the entity have the component --------- Co-authored-by: Josh Field <10372036+HexaField@users.noreply.github.com> * [IR-10167] Non serialized entities are being overridden by authoring layer (#1902) Entities can be serialized * add filtering logic to exclude directories in getFileKeysRecursive (#1898) * add filtering logic to excluse directories in getFileKeysRecursive * please the Prettier with slightly less readable code * fix: Update to fix lint message --------- Co-authored-by: Santiago Garza <8662253+sfgarza@users.noreply.github.com> * Add cycle-import-check to package scripts (#1871) * Import cycles cleanup * Update TransformComponent.ts * remove import plugin * Add cycle-import-check to package scripts * Add cycle-import-check to package scripts * update dimension generation to ignore mateiral and lookdev assets (#1869) * fix: exclude folders in getFileKeysRecursive (#1906) * Ir 6677 implement new UI visualizers icons and volumes ( functionality only ) (#1236) * build basic icon gizmo functionality * add more params to ActiveHelperComponent * fix issue with camera nodeHelper layer being disabled * render sprites * remove sprite functions * add grow effect on hover * remmve console log * add directional tag for directional gizmos * add directional arrow * add icons for the gizmos * setup consistent icon size relative to camera, update selection on gizmo down * finish off the system * remove comments * make axis line for all entities * specify transform component gizmo name and revert use of camera distance component * use use selected entities * get reference to simulation layer from authoring to use selected Entities * refactor(gizmos): reorganize imports and update function references for camera and transform gizmos * make common function for camera factor * fix some helper entities not configured properly * fix broken test * update UUID generation method * fix studio icon sizes * fix imports to transformg gizmo * fix up heuristic * setup the viewport icons and fix minor bugs * update with query reactor * make helper use start position and world rotation * fix schema issues and import issues * add active helpers to more components * replace icon retrieval name from name to jsonID in componentStudioIcon * add consideration for hover and selected states in activeHelper * make execute in active helper system not reactive * make hemishpere lightgizmo better * add volume to collider component * fix bounding box and change conditions for volume * finish up ui visualizers * boundingboxcomp-import * fix spline component * spline-helper * ch-br * test * testing * feat: clamp size of icons --------- Co-authored-by: sybiote <ghoshr698@gmail.com> Co-authored-by: hzraslan <hzraslan@gmail.com> * IR-9130 Add IP geolocation functionality and settings (#1897) * Add IP geolocation functionality and settings - Introduced IP geolocation API URL and token in environment configuration. - Updated moderation schema to include reported and reporting user country fields. - Enhanced UserInfo component to display user country. - Implemented IP geolocation settings in server configuration and seed data. - Added migration scripts for new country columns and IP geolocation settings. - Created helper function to fetch country from IP address using ipinfo.io API. - Support for user country in moderation report * Refactor generateSeedData function to remove optional jsonKey parameter from items * Remove hardcoded IP geolocation API token and update seed data to use environment variable * Update ip-geolocation-helper.ts * Fix string quotes in getCountryFromIP function * Refactor logging in getCountryFromIP function to use multiLogger * Refactor migration to add country columns for reported and reporting users * Refactor IP geolocation migration to streamline settings insertion and improve lookup efficiency --------- Co-authored-by: Hanzla Mateen <hanzlamateen@live.com> * IR-9128 Add user login history feature with modal and table display in moderation (#1918) Add user login history feature with modal and table display in moderation - Introduced UserLoginHistoryModal component to display login history for a specific IP address. - Updated ModerationDetail to include a button for viewing login history. - Added new translations in admin.json for login history. - Created constants for login history table columns. - Refactored UserLastLoginInfo to use destructured props. Co-authored-by: Hanzla Mateen <hanzlamateen@live.com> * Clean up model loading spinner (#1914) fix model loading spinner Co-authored-by: lonedevr <102248647+AidanCaruso@users.noreply.github.com> * Compression GLB/GLTF can fail (#1920) compress-bug * compress apartment sky station skyboxes (#1913) * move rfc6902 dep to engine package (#1915) * Replace Material Prototypes with Components (#1772) * start reworking prototypes into plugins * remove material prototype and parameters * clean up exporter tests * rework material instance state * rework material editor, material parameters and introduce defineMaterialPlugin API * revert apartment * license * make update arg optional, update plugins * update more plugins, add reactor arg * bug fixes * add material proxification * rework material dnd * Add unit tests for replaceMaterialAtIntersection function * Refactor MaterialComponent and getIntersectingNode functions; remove unused imports and add layers to query * fix errors in avatar transparency system * Enhance useExecute to support optional UUID; clean up MaterialPluginComponents and update related imports * fix tests * fix uuid tests * update timeouts * bug fixes * Merge branch 'dev' into IR-9161-Replace-all-custom-material-classes-with-OBC-Plugin-Components * fix improts * Refactor MaterialEditor and ParameterInput to use 'path' instead of 'entity' for better clarity and consistency; remove unused materialEditor component. * Update UUIDComponent tests and MaterialComponent to use UUIDComponent.get for improved clarity; add entitySourceID and entityID to test setups. * Add UUIDComponent setup to MaterialComponent and materialFunctions tests for improved entity identification * more bug and test fixes * Add Transparency Dithering plugin and related shader chunks; refactor imports for consistency * IR-8954: Thumbnail generation causes massive re renders and flashes (#1859) * IR-8954: re-add M. Floyd's fix * remove console.logs * temp fix re-export new engine-setting also as client-setting (#1866) * temp fix re-export new engine-setting also as client-setting * remove blank line * fix scene delta migration * add authoring state test for scene delta to override migration * texture support in material plugins * fix tests * test case * Update tsconfig.json to exclude test files from compilation * Enhance addMediaNode function to accept screen position and update related components for improved media placement * disable prototype editing * fix a variety of bugs * prototype fixes * remove texture info from texture schema type * fix bug with bake reactivity on materials * better migration strategy for EE_material * update material editor to synchronize parameter changes with material properties * fix texture and color material property editing * fix texture loading and color space assignment in material editor * update default args, move material updates inside authoring state * fix defaults in material editor * overwrite material instead of adding new one for time being * commit snapshot upon material plugin changes * disable test for now --------- Co-authored-by: Sam Young <svyoung@users.noreply.github.com> Co-authored-by: infinitelos <150717186+infinitelos@users.noreply.github.com> Co-authored-by: AidanCaruso <jamesajcme@gmail.com> Co-authored-by: lonedevr <102248647+AidanCaruso@users.noreply.github.com> * IR-9737: load mesh name from node instead of mesh data (#1921) fix: load mesh name from node instead of mesh data * IR-10194 Add support for mt-prdmirr, mt-nightly, and mt-weekly app hosts (#1910) feat(builder): add support for mt-prdmirr, mt-nightly, and mt-weekly app hosts Add environment detection for production mirror (mt-prdmirr), nightly build (mt-nightly), and weekly build (mt-weekly) deployments to builder scripts to ensure proper handling in GCP artifact repositories. * IR-9966: fix GLTF load progress (#1901) fix: set GLTF load progress * Enables spline componenet through feature flags (#1919) Co-authored-by: quaiquai-ir <matthew.mcquaigue@infinitereality.com> * IR-8741 unit tests gltf loading scene scenes (#1903) * adds scene loading tests * adds a nodes prop --------- Co-authored-by: quaiquai-ir <matthew.mcquaigue@infinitereality.com> * IR-9309 Add support of copy embed code in the publish modal (#1868) * Add EmbedCodeField component and integrate it into CopyEmbedCodePopover * Add EmbedCodeField to AddEditLocationModal for scene URL generation * update embed code structure and styling for improved compatibility * update embed code field to use location URL instead of scene resource * replace CopyEmbedCodePopover with InputDialog for embedding code functionality * replace useTranslation with i18next import in InputDialog * update copyright year to 2025 in EmbedCodeField component * update copy embed code logic to fetch location dynamically * update embed code URL to use dynamic location data * Add embed code handling and user prompts for scene publishing --------- Co-authored-by: Hanzla Mateen <hanzlamateen@live.com> * fix duplicate ignoring transform (#1926) * IR-9742: Create Inspector panel component (#1842) * init save * save progress 1.0 * resolve conflicts * clean up code * IR-9742: change css * IR-9742: code clean up * IR-9742: change to grid css * IR-9742: add storybook * IR-9742: add storybook * IR-9742: persist inspector panel on checkbox toggle * clean up code and fix storybook clean up code and fix storybook * check-errors fix * removed the progress logic that was incorrectly connecting the GTLF file download progress with GTLF component loading progress (#1936) * removed the progress logic that was incorrectly connecting the GTLF file download progress with GTLF component loading progress * updated comment * updated comment * [IR-7631] Colliders spawn world zero (#1833) * Tool tip edit * Check if physic world has rigidbody entity * Revert * Update prefab transform matrices after re-parenting * fix non deterministic loop anim tests (#1935) * log cleanup (#1938) * [IR-4969] Update Editor Toolbar controls (#1892) * add asset processing system in FileThumbnailJobState (#1923) * add asset procesing system in FileThumbnailJobState * fix switch case * Fix sync local storage not always syncing state (#1927) * [MT-DEV] Studio: Error displayed on the Video component (#1944) * updated the prefab file for the video corrected issue with the prefab loading using the root entity's source id as it's own source id. * updated uuid to use a generate * Remove unused CLI browser bridge plugin and update guidelines for development environment (#1928) * Add Type naming conventions to Eslint Config (#1945) * Add basic eslint naming convention rules * remove variable rule * fix type naming conventions * [IR-8591] Fix Instanced Variants (#1934) * Variant instance tests * Test * Cleanup * Remove act renders * [IR-8941] Enum schemas should save enum values instead of index (#1876) * Replace enums with const values * Input component * Cleanup missed schema options * Tests * Enum metadata * Const to enum * Incomming changes conflict resolution * Move to metadata * index to value * Test * Update comments to represent enum values --------- Co-authored-by: Josh Field <10372036+HexaField@users.noreply.github.com> * Networked Hyperflux (#1557) * clean up some imports in network package, set up peerindex generation based on peer uuid * separate media channel from data channel properly * refactor peer media state to use media channel types * restructuring and renaming network functions * remove unused deprecated onCreate api * some more cleanup * start moving network package into hyperflux and ecs * fixing imports * format * update all other refs to network package * fix test * add license * update new tests * update build script * update license * IR-8744 unit tests gltf loading extras (#1942) * adds gltf test for extras * removes comment --------- Co-authored-by: quaiquai-ir <matthew.mcquaigue@infinitereality.com> * Optimize flow should limit texture size to 1K (#1943) bef-ch * IR-10272: Fix scene update logic in AddEditLocationModal (#1949) Fix scene ID update logic in AddEditLocationModal * Storybook Additional Stories (#1932) * init commit * update to glass * better grouping * msw setup * msw example * wip * working scene * refactor engine decorator * update decorator * update preview * relodable engine * wip * scene loading mvp * scene loader component * fix module declaration issue * toggle scenes * PR cleanup * disable https * make example scene * add example story * remove settings component * remove settings story * always enable hyperflux * add ts ignore * remove extra deps * move storybook to top * remove sb from ui * add client core avatar components * Revert "remove sb from ui" This reverts commit 96e71ca. * Revert "move storybook to top" This reverts commit 93739c3. * add storybook to client-core * add client-core pt1 * client-core pt2 * client-core pt2.1 * add server stories * move types to _global * add ts-ignore * cleanup * exclude broken stories... yeesh * update staticDirs * IR-4977-Replace-usage-of-UpdatableComponent-with-systems (#1937) Co-authored-by: Tavius Koktavy <tavius@nyu.edu> * [IR-8209]: Fix recursive folder search in GCS & S3 storage providers (#1940) fix: extract sub-folder from file keys * Fix: improve entity label rendering to handle new UUIDComponent (#1916) * fix: improve entity label rendering to handle unknown components * Refactor entity label rendering to simplify optional component checks --------- Co-authored-by: lonedevr <102248647+AidanCaruso@users.noreply.github.com> Co-authored-by: Gheric Speiginer <gheric.speiginer@gmail.com> * IR-6715 Fix the Environment Map Bake component (#1924) * Use generateEnvmapBake for all envmap creation * Update to new viewerEntity access pattern * Append timestamp to envmap file to ensure visual updates * Bake position uses entity pos+offset, and returns a new vector for update safety * Bug fix for box projection shader * Error handling around box projection plugin * Remove check to add EnvMapBakeComp since this func only runs via Bake button on comp * Update envmap with correct position and box projection status * Use new reactor pattern to pass entity as prop * Error handling for removed BoxProjection plugin * Use URL hash for cache busting instead of timestamp --------- Co-authored-by: Josh Field <10372036+HexaField@users.noreply.github.com> * Compression GLB/GLTF can fail (#1939) * video-image-transform * basic-cleanup * clean-up * compression-error * error-message * simplify * simplify * simplify * filename * revert-comment * IR-9980: Fix lock and visibility icons shifting off-screen (#1947) * fix: Fix lock and visibility icons shifting off-screen by keeping them fixed to the right * chore: removed fixed width * chore: format * IR-10221 Remove AnimateScaleComponent (#1955) * Remove unused AnimateScaleComponent * Remove other unused InputComponent code * Replace usage of useEntityContext in InputComp * Update deprecated code and remove useExecuteWithInput overrides * Update useExecuteWithInput tests * Revert "Update useExecuteWithInput tests" This reverts commit 5bddf28. * Revert "Update deprecated code and remove useExecuteWithInput overrides" This reverts commit 951fa3e. * Revert "Replace usage of useEntityContext in InputComp" This reverts commit d4d8e1e. * Revamp Chat Page (#1863) * new chat page * Refactor chat components for improved layout and remove unused state * Add new message button to ConversationList and update layout * Refactor media instance provisioning and conversation window for improved state management and clarity * exclude world instance chat from DMs * fix bugs with friends menu * Refactor video call components for improved state handling and layout; update instance schema to allow optional projectId * Update Chat UI implementation roadmap with detailed phases and tasks for core functionality and enhancements * Implement message timestamp formatting and add last message retrieval to channel schema * Add message timestamps and improve scrolling behavior in ConversationWindow * Enhance chat state management by syncing current page with local storage and improve workspace button styling with Tailwind CSS * Update guidelines and enhance todo list for chat UI development phases * Refactor state management in chat components to use Hookstate for improved reactivity * Add workspace and member management to chat state, including UI updates for workspace selection and member sidebar toggle * Refactor GlobalNavPane and WorkspaceList components for improved UI and functionality, including workspace selection and button styling updates * Add media session state management and volume control UI components * Add media session localization strings for control options * Add resizable video container with localStorage persistence in ConversationWindow * Enhance media stream state management in VideoCall component to accurately reflect audio and video pause states for self and screen sharing * Add GlobalVideoCallPopout component and enhance media session state management for popout functionality * Add call participants display and custom hook for managing call participant state in ConversationWindow * fix errors * Enhance channel creation logic to find existing channels with exact user matches and improve test coverage for channel creation scenarios * Remove commented-out code and improve readability in various components * remove old chat page * Refactor media channel state management in chat components * remove logs * Fix bugs with setting root state and add unit tests for syncStateWithLocalStorage (#1960) * Fix bugs with setting root state and add unit tests for syncStateWithLocalStorage * fix test regressions * unblock IR-8127: fix hardcode value of max user per instance number by default (#1948) * wip * fix hardcode value of max user per instance number by default * adding missing engine-setting migration * Split maxUsersPerInstance into separate public seed generateSeedData applies the same type to everything in the array, needed to make this separate so it would be public on dev-reinit * Generate maxUsersPerInstance separate from other instance-server seeds generateSeedData applies the same type to everything in the array, needed to make this separate so it would be public on dev-reinit * fix save with submit save button instead on change of input --------- Co-authored-by: Kyle Baran <kbaran@bitscoop.com> * Update gizmo visibility logic based on active helper component state (#1922) * Update gizmo visibility logic to depend on active helper component state * Enhance gizmo visibility logic to include editor helper state * fix: correct gizmoEnabled state access in ActiveHelperReactor * Remove NameComponent.getEntitiesByName (#1946) * Remove NameComponent.getEntitiesByName Refactor AvatarIKComponents and NameComponent to use UUID for entity identification * Disable validation for NameComponent schema due to issues with custom onSet * Refactor exportGLTFScene tests to remove redundant NameComponent assignments * Remove reflection probes implementation (#1933) * Temp Fix: Filter "Probes" from the EnvMap dropdown * Remove reflection probes * IR-8739 Adds tests for gltf nodes and connected properties (#1954) * Adds tests for gltf nodes and connected properties * moves unimplemented to todo, adds componenet id, adds flushAll --------- Co-authored-by: quaiquai-ir <matthew.mcquaigue@infinitereality.com> * Add request and resolved time tracking to API debug and Feathers hooks (#1969) * IR-9735: F key focus, highlighting hierarchy (#1957) * init * IR-9735: F key focus, click will scroll down to entity list * clean up * sorry, another cleanup * remove dupliate variables * clarify comments * fix non collapsing parent entity bug * IR-8742 adds tests for GLTF skins. Adds Export for loadSkins for testing (#1962) * wip - adds tests for GLTF skins. Adds Export for loadSkins for testing * Adds skins tests * removes AI comments and commented out code. --------- Co-authored-by: quaiquai-ir <matthew.mcquaigue@infinitereality.com> Co-authored-by: Josh Field <10372036+HexaField@users.noreply.github.com> * Feature Flagged Viewer Menu (#1974) [IR-9597] Add Glassmorphism structure (#1899) [IR-9597] [IR-9602] Viewer Glassmorphism structure Co-authored-by: Chris Dolphin <chris.dolphin@theinfinitereality.com> * Fix recursive rerender and improve reactor debug tool (#1956) * Fix recursive rerender and improve reactor debug tool * stable useExecute UUIDs * disable nested model entity networking * Flip Glassmorphism feature flag (#1980) * IR-10146 mt stg user spawns beneath the floor (#1931) * adds collider loading spawn system and state to prevent avatar from falling * Removes Collider loader solution and adds collider as dependency to GLTF loading * removes comment * wip * some clean up * remove console log * remove console and add back undefined check * fix rigidbody import * adds hasColliders to ColliderComponent schema, Creates a useCheckLoadedColliders effect to check that all collider entites have a loaded collider before fully loading GLTFComponent * adds checks * fixes issue causing tests to fail * small cleanup * replacing changed code * fixes collider dependency issue by removing scene component active property * changes to inline --------- Co-authored-by: quaiquai-ir <matthew.mcquaigue@infinitereality.com> * Proper Resource Caching And Refetching (#1421) * IR-5334-remake-again * wip * wip * wip * switch to hookstate/core w/ patch * hookstate patch, fix recursive render in environment system, fix reactor debugger * fix error * fix bugs with compressed textures in texture manager, some cleanup * promise caching * Update package.json * Update ResourceState.tsx * Update AvatarSpawnSystem.test.tsx * move resource patch from spatial to engine * use cache in avatar spawn system again * wrap offloadTextureData in a prototype override to fix cyclical imports * disable shader error checking in development mode * disable log * add logs * fix some getComponent calls with missing components * add logs * Update dexie and improve resource cache typings * Update EnvironmentSystem.tsx * clean up AI comment slop * add timeout for variant component test --------- Co-authored-by: Gheric Speiginer <gheric.speiginer@gmail.com> * [IR-6731] Add abort controller into each GLTF loader dependency (#1967) * Port from branch off of resource caching branch * Errors fixes * cleanup --------- Co-authored-by: HexaField <joshfield999@gmail.com> --------- Co-authored-by: Muhammad Shafiq <shafiqkhuidad@gmail.com> Co-authored-by: Hanzla Mateen <hanzlamateen@live.com> Co-authored-by: Appaji <52322531+CITIZENDOT@users.noreply.github.com> Co-authored-by: Chris Dolphin <chris.dolphin@theinfinitereality.com> Co-authored-by: Tavius Koktavy <tavius@nyu.edu> Co-authored-by: Michael Estes <michael@etherealengine.com> Co-authored-by: lonedevr <102248647+AidanCaruso@users.noreply.github.com> Co-authored-by: HexaField <joshfield999@gmail.com> Co-authored-by: Josh Field <10372036+HexaField@users.noreply.github.com> Co-authored-by: Rahul Ghosh <ghoshr698@gmail.com> Co-authored-by: hizir aslan <35542226+hzraslan@users.noreply.github.com> Co-authored-by: Sam Mazer <sam.mazer@theinfinitereality.com> Co-authored-by: Sam Mazer <162159423+SamMazerIR@users.noreply.github.com> Co-authored-by: Adrian Cacho <Tortillaguy@users.noreply.github.com> Co-authored-by: Andy Chen <44120813+achen5671@users.noreply.github.com> Co-authored-by: MoizAdnan <moizadnan21@gmail.com> Co-authored-by: quaiquai-ir <matthew.mcquaigue@theinfinitereality.com> Co-authored-by: quaiquai-ir <matthew.mcquaigue@infinitereality.com> Co-authored-by: Sam Young <svyoung@users.noreply.github.com> Co-authored-by: infinitelos <150717186+infinitelos@users.noreply.github.com> Co-authored-by: Gheric Speiginer <gheric.speiginer@gmail.com> Co-authored-by: Daniel Belmes <3631206+DanielBelmes@users.noreply.github.com> Co-authored-by: Kyle Baran <kbaran@bitscoop.com> Co-authored-by: Adrian <agcacho22@gmail.com> Co-authored-by: MbfloydIR <144718558+MbfloydIR@users.noreply.github.com> Co-authored-by: Armando Salazar <armando.salazar@theinfinitereality.com> Co-authored-by: Andres Jimenez <andresdavid@outlook.com> Co-authored-by: José Galván <33644205+jose-galvan@users.noreply.github.com> Co-authored-by: Chris Dolphin <dolphin@likethemammal.com> Co-authored-by: aditya-mitra <55396651+aditya-mitra@users.noreply.github.com> Co-authored-by: Andres <asulbaran@theinfinitereality.com> Co-authored-by: Armando Salazar <121046819+armando-salazar@users.noreply.github.com> Co-authored-by: hzraslan <hzraslan@gmail.com> Co-authored-by: Jeremy Sachs <jeremysachs@rezmason.net> Co-authored-by: Junhua Chang <junhua.chang@theinfinitereality.com> Co-authored-by: Jiatong Yao <142644522+JT00y@users.noreply.github.com> Co-authored-by: Matthew Bogard <33242750+BogieBogard@users.noreply.github.com> Co-authored-by: Moiz Adnan <67912355+MoizAdnan@users.noreply.github.com> Co-authored-by: Miguel <113119956+mikeplascdev@users.noreply.github.com> Co-authored-by: Santiago Garza <8662253+sfgarza@users.noreply.github.com> Co-authored-by: AidanCaruso <jamesajcme@gmail.com> Co-authored-by: Santiago Garza <santiago.garza93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor AvatarIKComponents and NameComponent to use UUID for entity identification
Summary
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps