standardize gizmo creation in the engine #1961
Open
+1,888
−953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved `useHelperEntity` from `@ir-engine/spatial/src/common/debug/useHelperEntity` to `@ir-engine/spatial/src/helper/functions/useHelperEntity`. - Updated imports in various components to reflect the new location of `useHelperEntity`. - Removed the old `useHelperEntity` file and its associated code. - Introduced new helper components for directional, hemisphere, point, spawn, and spot lights, including their respective reactor functions and registry entries. - Simplified the `BoundingBoxComponent` by removing unnecessary dependencies on helper visibility states. - Added `ActiveHelperRegisterSystem` to populate the helper registry with icons and components for various light types.
…n-across-spatial-and-editor-package
…n-across-spatial-and-editor-package
…tion to include new helper files
…streamline component usage
HexaField
reviewed
May 30, 2025
…n-across-spatial-and-editor-package
… improved clarity and consistency
…patial-and-editor-package' of https://github.com/ir-engine/ir-engine into IR-10220-standardize-helper-and-gizmo-creation-across-spatial-and-editor-package
…tLightComponent reactor logic
…Component references. Update ComponentHelperState and related reactors to streamline functionality and enhance performance.
…Component based on its presence. Remove debug log for cleaner output.
…ure BoundingBoxComponent is set or updated based on selection and hover states.
…nent reactor cleanup
…n-across-spatial-and-editor-package
…nate unused components.
…rove entity existence checks in ActiveHelperReactor.
…treamline input handling; add BOUNDING_BOX_COLORS for consistent color management in BoundingBoxComponent.
…ic and streamline input handling; add BOUNDING_BOX_COLORS for consistent color management in BoundingBoxComponent." This reverts commit 594c974.
…lity logic and streamline input handling; add BOUNDING_BOX_COLORS for consistent color management in BoundingBoxComponent."" This reverts commit 91e8586.
…per entity management
… management; integrate BOUNDING_BOX_COLORS for hover effects
…n-across-spatial-and-editor-package
…, refactor ActiveHelperReactor for priority handling, and introduce HelperComponent for better entity management.
SamMazerIR
approved these changes
Jun 4, 2025
|
some errors to fix |
…n-across-spatial-and-editor-package
DanielBelmes
previously requested changes
Jun 5, 2025
…oved type safety; update studioIconGizmoHelper to enhance icon scaling logic
|
@DanielBelmes , fixed it |
HexaField
previously requested changes
Jun 5, 2025
packages/spatial/src/transform/components/BoundingBoxComponent.ts
Outdated
Show resolved
Hide resolved
…ts for visibility and selection
…n-across-spatial-and-editor-package
…n-across-spatial-and-editor-package
…note relocation to editor package
…ences from light component tests
… prevent execution during testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove activeHelperCommponent
provide each helper its own reactor
manage helpers via reactor injection system
hope the video helps review efforts
Screen.Recording.2025-06-04.092553.mp4