Monitoring otel #1975
Draft
Monitoring otel #1975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to monitoring-otel
HexaField
requested changes
May 28, 2025
| @@ -140,6 +141,30 @@ const ConnectionReactor = (props: { instanceID: InstanceID; topic: Topic }) => { | |||
| API.instance.service(instanceSignalingPath).get({ instanceID }) | |||
| }, 5000) | |||
|
|
|||
| // Track P2P metrics if the service is available (enabled via environment config) | |||
| const instance = getState(PeerToPeerNetworkState)[instanceID] | |||
There was a problem hiding this comment.
can we do this on the backend instead
| /** | ||
| * Configure monitoring for the application | ||
| */ | ||
| export default (options = {}) => { |
There was a problem hiding this comment.
this isn't how the rest of the codebase handles exporting a group of services, instead we just export an array of the service factory functions
| /** | ||
| * MetricsService class for handling Prometheus metrics | ||
| */ | ||
| export class MetricsService { |
There was a problem hiding this comment.
shouldn't this data go into the database such that we don't store data in memory? How does this work across multiple API servers?
| /** | ||
| * TracingService class for handling OpenTelemetry tracing | ||
| */ | ||
| export class TracingService { |
There was a problem hiding this comment.
we prefer functions over classes, please make this a functional implementation if possible
…; modified to follow current practices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add prometheus client endpoint
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps