IR-9784 IR-9782 camera poi guided control and direct control modes #1996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…being hidden under it's html elements
… and modified default values
…nto IR-9782-camera-poi
…ollowCameraInputSystem
HexaField
previously requested changes
Jun 5, 2025
consolidated createPoiUI and createPoiUiView into one function
HexaField
reviewed
Jun 5, 2025
| setCanvasWidth(rendererComponent.canvas.value.width) | ||
| setCanvasHeight(rendererComponent.canvas.value.height) | ||
| }, [rendererComponent.canvas, rendererComponent.needsResize]) | ||
| setCanvasWidth(rendererComponent.canvas.value.clientWidth) |
There was a problem hiding this comment.
this can be simplified to const canvas = rendererComponent.canvas.value?.clientWidth ?? 0 and get rid of the useEffect
| const cameraSettingsState = useMutableState(CameraSettingsState) | ||
|
|
||
| // State for reactive boolean variables | ||
| const [showPrevious, setShowPrevious] = useState(false) |
There was a problem hiding this comment.
we prefer to use hookstate instead of react for state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
(some terminology in the tickets need work)
adding guided camera (POI list transitioning with either snapping or smooth scroll transitioning)
References
https://tsu.atlassian.net/browse/IR-9784
https://tsu.atlassian.net/browse/IR-9782
QA Steps
go to Settings entity, and scroll to CameraSettings
go to camera mode and choose either Direct or POI
for Direct you now have the option whether to spawn an avatar and multiple other settings listed in 9782
for POI you will be able to add and remove to a list, where each element can choose from entities in the scene with a Camera POI Component. the camera will begin on the first element's location+rotation, and transitions will move up or down the list with either scrolling or the optional UI buttons.
choose from smooth scrolling or snapping behavior to move between elements, and wrap/clamp to either circularly wrap around the list when reaching the ends or stopping at the ends