8000 fix(editor): lookdev drag drop [IR-9728] by mikeplascdev · Pull Request #2009 · ir-engine/ir-engine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(editor): lookdev drag drop [IR-9728] #2009

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

fix(editor): lookdev drag drop [IR-9728] #2009

wants to merge 8 commits into from

Conversation

mikeplascdev
Copy link
Contributor
@mikeplascdev mikeplascdev commented Jun 3, 2025 •
8000
edited by jira bot
Loading

Summary

  • Validate empty states and add logs

Subtasks Checklist

Breaking Changes

References

closes #insert number here

QA Steps

  1. Open studio project
  2. Create new scene
  3. Select Files menu (IR logo) dropdown > Export Lookdev Prefab
  4. Name custom prefab and confirm
  5. Find the customized prefab in Files tab
  6. Drag prefab into viewport

Evidence

Screen.Recording.2025-06-02.at.11.09.56.p.m.mov

Jira

IR-9728

@mikeplascdev mikeplascdev self-assigned this Jun 3, 2025
HexaField
HexaField requested changes Jun 3, 2025
View reviewed changes
@mikeplascdev mikeplascdev requested a review from HexaField June 4, 2025 02:10
jose-galvan
jose-galvan requested changes Jun 5, 2025
View reviewed changes
Copy link
Contributor
@jose-galvan jose-galvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting this error:
image

HexaField
HexaField requested changes Jun 5, 2025
View reviewed changes
packages/engine/src/authoring/AuthoringState.tsx
// use an empty string to denote the root of the source
let parentEntityID = ''
if (entityTree.parentEntity !== sourceEntity && hasComponent(entityTree.parentEntity, UUIDComponent)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all entities loaded into the authoring layer should have a UUIDComponent, we need to investigate why this is necessary if it really is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HexaField HexaField HexaField requested changes

@jose-galvan jose-galvan jose-galvan requested changes

@Tortillaguy Tortillaguy Tortillaguy approved these changes

@DanielBelmes DanielBelmes Awaiting requested review from DanielBelmes

@SYBIOTE SYBIOTE Awaiting requested review from SYBIOTE

@AidanCaruso AidanCaruso Awaiting requested review from AidanCaruso AidanCaruso is a code owner

@MichaelEstes MichaelEstes Awaiting requested review from MichaelEstes MichaelEstes is a code owner

@dinomut1 dinomut1 Awaiting requested review from dinomut1 dinomut1 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@mikeplascdev mikeplascdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikeplascdev @HexaField @Tortillaguy @jose-galvan
0