Added retry plugin to octokit #2015
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pushing projects to GitHub was often running into ETIMEDOUT errors when uploading blobs. This would cause the whole push to error out. It's unclear why, but it may have been due to rate limiting, since a lot of files were being uploaded for certain projects. Enabled the retry plugin for octokit, which will retry failed requests. In limited testing with projects exhibiting this behavior, this seemed to solve the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pushing projects to GitHub was often running into ETIMEDOUT errors when uploading blobs. This would cause the whole push to error out.
8000 It's unclear why, but it may have been due to rate limiting, since a lot of files were being uploaded for certain projects.
Enabled the retry plugin for octokit, which will retry failed requests. In limited testing with projects exhibiting this behavior, this seemed to solve the problem.
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps