8000 fix(IR-10576): improve Kaniko log capture to prevent missing build errors by kattsushi · Pull Request #2019 · ir-engine/ir-engine · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(IR-10576): improve Kaniko log capture to prevent missing build errors #2019

8000 New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2025
Merged

fix(IR-10576): improve Kaniko log capture to prevent missing build errors #2019

merged 1 commit into from
Jun 4, 2025

Conversation

kattsushi
Copy link
Contributor
@kattsushi kattsushi commented Jun 4, 2025 •
edited by jira bot
Loading

Summary of Changes

Problem
The Kaniko log parsing system was missing errors in some scenarios where pods failed. This occurred because the log capture logic was not capturing logs at the right moment, particularly when pods transitioned from a running state to a failed/error state.

Changes Made

Enhanced the wait_for_builds_finished() function to:

  • Capture logs for all pods regardless of their status (not just Running or Pending)
  • Track which pods have already had their logs captured using environment variables
  • Ensure final logs are captured before the function returns

Improved the record_build_error() function to:

  • Capture logs one final time to ensure the latest information is available
  • Check for errors in both standard output and error logs
  • Display more detailed error information when errors are found
  • Use pattern matching to identify errors in log files

Breaking Changes

References

Jira Ticket IR-10576

QA Steps

@kattsushi kattsushi self-assigned this Jun 4, 2025
@kattsushi kattsushi requested a review from hanzlamateen as a code owner June 4, 2025 17:31
@kattsushi kattsushi requested a review from infinitelos June 4, 2025 17:36
@barankyle barankyle added this pull request to the merge queue Jun 4, 2025
Merged via the queue into dev with commit e7df344 Jun 4, 2025
24 checks passed
@barankyle barankyle deleted the IR-10576-current-kaniko-log-parsing-sometimes-misses-errors branch June 4, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barankyle barankyle barankyle approved these changes

@infinitelos infinitelos infinitelos approved these changes

@DanielBelmes DanielBelmes Awaiting requested review from DanielBelmes DanielBelmes is a code owner

@hanzlamateen hanzlamateen Awaiting requested review from hanzlamateen hanzlamateen is a code owner

Assignees

@kattsushi kattsushi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kattsushi @barankyle @infinitelos
0