Avatar preview menu fix and proper entity array boundary usage #2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-user-when-user-closes-avatar-selection-page-via-x-button
jose-galvan
reviewed
Jun 6, 2025
There was a problem hiding this comment.
I tested these changes because they also resolved another issue where duplicated assets in the scene were only rendering once.
However, I noticed a problem when updating transform properties from an entity in the hierarchy, the changes aren't persisted. The position reverts instantly, even though the input reflects the updated value, it doesn't seem to apply correctly to the component. See the video attached.
Screen.Recording.2025-06-06.at.10.30.37.a.m.mov
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Subtasks Checklist
Breaking Changes
References
closes #insert number here
QA Steps