8000 Disallow : as the first character of metadata keys by progval · Pull Request #567 · ircv3/ircv3-specifications · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Disallow : as the first character of metadata keys #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

progval
Copy link
Contributor
@progval progval commented Jun 21, 2025 8000

It can't be serialized as a non-trailing parameter, eg. in 'METADATA '

Found by @slingamn

It can't be serialized as a non-trailing parameter, eg. in
'METADATA <Target> <Key> <Visibility> <Value>'
@jwheare
Copy link
Member
jwheare commented Jun 21, 2025

Do we maybe want to disallow : from keys entirely for simplicity's sake?

@progval
Copy link
Contributor Author
progval commented Jun 21, 2025

sure, why not

Copy link
Contributor
@slingamn slingamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Credit for finding this goes to @thatcher-gaming

slingamn added a commit to slingamn/ircv3-specifications that referenced this pull request Jun 22, 2025
* Disallow colon entirely as in ircv3#567
* Disallow A-Z
* Remove requirement of case-insensitive handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0