8000 Update members.yaml by yuluo-yx · Pull Request #1629 · istio/community · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update members.yaml #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2025
Merged

Update members.yaml #1629

merged 1 commit into from
Jun 22, 2025

Conversation

yuluo-yx
Copy link
Member
@yuluo-yx yuluo-yx commented Jun 22, 2025 •
edited
Loading

I want to join the Istio org!

@yuluo-yx yuluo-yx requested a review from a team as a code owner June 22, 2025 02:54
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Jun 22, 2025
@istio-testing
Copy link
Contributor

Hi @yuluo-yx. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yuluo-yx
Copy link
Member Author

/cc @craigbox

@kfaseela
Copy link
Member

/ok-to-test

@kfaseela
Copy link
Member

Welcome!

@istio-testing istio-testing merged commit 8f1cf40 into istio:master Jun 22, 2025
4 checks passed
@yuluo-yx yuluo-yx deleted the patch-1 branch June 22, 2025 05:41
@yuluo-yx
Copy link
Member Author

hi @kfaseela, sorry to bother you.

I have two questions. I read in the contribution role member description that as long as you become a member, you can use /ok-to-test, but I still can't do it. Do I need to join the istio github org? If so, what should I do?

istio/istio.io#16597 (comment)

@kfaseela
Copy link
Member

hi @kfaseela, sorry to bother you.

I have two questions. I read in the contribution role member description that as long as you become a member, you can use /ok-to-test, but I still can't do it. Do I need to join the istio github org? If so, what should I do?

istio/istio.io#16597 (comment)

I will take a look

@kfaseela
Copy link
Member

hi @kfaseela, sorry to bother you.

I have two questions. I read in the contribution role member description that as long as you become a member, you can use /ok-to-test, but I still can't do it. Do I need to join the istio github org? If so, what should I do?

istio/istio.io#16597 (comment)

I see that the post submit job has failed. Could you please check what is wrong with the github id you have specified?

https://prow.istio.io/view/gs/istio-prow/logs/sync-org_community_postsubmit/1936660016454963200

{"component":"unset","level":"fatal","msg":"Configuration failed: failed to configure istio teams: failed to update Members members: UpdateTeamMembership(members(Members), shown.ji, false) failed: status code 404 not one of [200], body: {\"message\":\"Not Found\",\"documentation_url\":\"https://docs.github.com/rest/teams/members#add-or-update-team-membership-for-a-user\",\"status\":\"404\"}","severity":"fatal","time":"2025-06-22T07:23:56Z"}

kfaseela
kfaseela reviewed Jun 22, 2025
View reviewed changes
org/members.yaml
@@ -422,6 +422,7 @@ members:
- shirleyyLi
- shivanshu1333
- shonecyx
- Shown.Ji
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your github id is yuluo-yx ?

8000

Copy link
Member Author
@yuluo-yx yuluo-yx Jun 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh~ thanks, my bad. 😥 I will update it

I thought the name here should be filled in with the same name as configured in my gitconfig

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @kfaseela , fixed it, PTAL. thanks

#1630

@yuluo-yx yuluo-yx mentioned this pull request Jun 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfaseela kfaseela kfaseela approved these changes

Assignees
No one assigned
Labels
ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuluo-yx @istio-testing @kfaseela
0