Support setting namespaces on gateway charts #32675
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morvencao
reviewed
May 17, 2021
Comment on lines
+73
to
+79
| {{- if $item.namespaces }} | ||
| namespaces: | ||
| {{- $ns := split "," $item.namespaces }} | ||
| {{- range $i, $n := $ns }} | ||
| - {{ $n | quote }} | ||
| {{- end }} | ||
| {{- end }} |
There was a problem hiding this comment.
Is the namespaces in affinity added after k8s 1.17?
There was a problem hiding this comment.
I think it was around from k8s 1.14.
There was a problem hiding this comment.
morvencao
approved these changes
May 17, 2021
|
/test integ-pilot-multicluster-tests_istio |
arka-pramanik-hpe
added a commit
to Cray-HPE/cray-istio
that referenced
this pull request
May 12, 2025
arka-pramanik-hpe
added a commit
to Cray-HPE/cray-istio
that referenced
this pull request
May 30, 2025
* Revamped Chart Structure since Istio Operator is deprecated now * Renamed cray-istio chart to cray-istio-ingress * Removed charts cray-istio-deploy and cray-istio-operator * Added charts cray-istio-base and cray-istio-pilot * Updated version tags and images * Updated LICENSES * Support setting namespaces on gateway charts (istio/istio#32675) * More consistent helm charts labels (istio/istio#52463) * By default, exclude gateways from ambient mesh enrollment (istio/istio#54825) * Upgrade docker-kubectl version * Modify rbac and change jwtPolicy * initial ClusterTrustBundle v1alpha1 support (istio/istio#55592) * Update Image and App version to 1.26.0 * Add a check before accessing the Values * Update chart values to comply with upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #32655