fix default kind config for prow #55959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In istio#55592, the default prow config was changed to include support for ClusterTrustBundles by default, which breaks on k8s<v1.27. This moves the ClusterTrustBundle enablement into a separate config, as it's only used in manual tests anyway. We can use the separate config when we write an integration test.
|
This should fix the failing postsubmit tests |
| @@ -0,0 +1,34 @@ | |||
| # This configs KinD to spin up a k8s cluster with ClusterTrustBundle support enabled | |||
| # This should only be used to create K8s clusters with versions >= 1.27 | |||
| kind: Cluster | |||
There was a problem hiding this comment.
Where is this Kind config used?
There was a problem hiding this comment.
not by anything in CI - it's only there for manual testing right now. We can use it when we add an integration test for ClusterTrustBundle
sridhargaddam
approved these changes
Apr 16, 2025
| @@ -0,0 +1,34 @@ | |||
| # This configs KinD to spin up a k8s cluster with ClusterTrustBundle support enabled | |||
| # This should only be used to create K8s clusters with versions >= 1.27 | |||
| kind: Cluster | |||
dhawton
approved these changes
Apr 16, 2025
howardjohn
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
In #55592, the default prow config was changed to include support for ClusterTrustBundles by default, which breaks on k8s<v1.27. This moves the ClusterTrustBundle enablement into a separate config, as it's only used in manual tests anyway. We can use the separate config when we write an integration test.