Fix e2e tests when using '--istio.test.revisions' to specify multiple revisions #56548
Conversation
|
Just making sure I understand, when we pass the compatibility flags and revisions flags, the test framework will create multiple echo deployments, one for each revision. In a lot of the tests, we send to the service, so we can't be sure which revision we'll end up at. |
Service name does not contain revision, so we should be good. Here I try to fix e2e tests related to deployments/pods, which have revision in their names. |
|
/test unit-tests |
|
cc @howardjohn, mind taking a look if you have a chance? Thanks a lot |
e203396 to
d7d0e7b
Compare
|
/test unit-tests-arm64 |
Please provide a description of this PR:
--istio.test.revisionsto specify multiple Istio revisions for the e2e tests, deployment names will append with the revision name. Here is the K8s yaml template: https://github.com/istio/istio/blob/1.26.1/pkg/test/framework/components/echo/kube/templates/deployment.yaml#L13-L17.TestServerRouting: make the expected podnames contains all items with certain subset version instead of only the first item.TestServiceRestart: make sure find the correct deployment names to restart when there are multiple Istio revision.