support reset log level or stack trace level separately for admin log #56642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xin.li <xin.li@daocloud.io>
Signed-off-by: xin.li <xin.li@daocloud.io>
|
/test integ-ds |
|
/test integ-security-multicluster |
|
/test integ-ds |
Stevenjin8
reviewed
Jun 23, 2025
Stevenjin8
reviewed
Jun 23, 2025
Stevenjin8
reviewed
Jun 23, 2025
istioctl/pkg/admin/istiodconfig.go
Outdated
| return &istiodConfigLog{state: &resetState{ctrzClient}} | ||
| } else if outputLogLevel != "" { | ||
| case logRest: |
There was a problem hiding this comment.
Also, does this mean that if both --log-reset and -stracktrace-reset are passed, only the log level will be reset?
There was a problem hiding this comment.
This is a problem. I just added a check to remind users that they cannot specify --log-reset and --stack-trace-reset at the same time.
Signed-off-by: xin.li <xin.li@daocloud.io>
Signed-off-by: xin.li <xin.li@daocloud.io>
Stevenjin8
reviewed
Jun 26, 2025
No, just an option, I re-evaluated it and specifying both seems better. I have updated and added the test. Please review again, thanks |
Signed-off-by: xin.li <xin.li@daocloud.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
Currently there is only one
--resetflag to reset the log level for both log and stack trace. It would be better to be able to reset two convenient log levels separately (like--leveland--stack-trace-levelfor each).To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.