8000 add clusterTrustBundle in feature table by AritraDey-Dev · Pull Request #56739 · istio/istio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

add clusterTrustBundle in feature table #56739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

add clusterTrustBundle in feature table #56739

wants to merge 12 commits into from

Conversation

AritraDey-Dev
Copy link
Member
@AritraDey-Dev AritraDey-Dev commented Jun 23, 2025 •
edited
Loading

Please provide a description of this PR:

add clusterTrustBundle in feature table (follow up of #56727)
Fixes #56367

@AritraDey-Dev
add clusterTrustBundle in feature table
7d7bf2b 
Fixes istio#56367

Signed-off-by: Aritra Dey <adey01027@gmail.com>
@AritraDey-Dev AritraDey-Dev requested a review from a team as a code owner June 23, 2025 18:23
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 23, 2025
@zirain
Copy link
Member
zirain commented Jun 24, 2025

can you add a e2e test for #56676 and #56675 before this happen?

do we need add this into https://github.com/istio/enhancements?

@AritraDey-Dev AritraDey-Dev requested a review from a team as a code owner June 24, 2025 18:56
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 24, 2025
@AritraDey-Dev
added tests for clusterTrustBundle
c83b565 
Signed-off-by: Aritra Dey <adey01027@gmail.com>
@AritraDey-Dev AritraDey-Dev force-pushed the cluster-trust-bundle-support branch from 0b5555a to c83b565 Compare June 24, 2025 18:58
@AritraDey-Dev
fix lint target
30e7ef3 
Signed-off-by: Aritra Dey <adey01027@gmail.com>
@AritraDey-Dev
lint: remove redundant else
74cc98f 
Signed-off-by: Aritra Dey <adey01027@gmail.com>
@AritraDey-Dev
fix namespace issue
60e527e 
Signed-off-by: Aritra Dey <adey01027@gmail.com>
@AritraDey-Dev
fix test path
8cb5e1d 
Signed-off-by: Aritra Dey <adey01027@gmail.com>
@AritraDey-Dev
wait for the crd to be ready
74c4d1e 8000 
Signed-off-by: Aritra Dey <adey01027@gmail.com>
@AritraDey-Dev
remove unnceasary wait from ctb
dc4a15b 
Signed-off-by: Aritra Dey <adey01027@gmail.com>
@AritraDey-Dev
Copy link
Member Author

@zirain any thoughts on the tests?looks like I am making mistake in ns

@zirain
Copy link
Member
zirain commented Jun 25, 2025

I think you should install a new suite with the feature flag on and run some basic taffice test.

cc @dgn

@AritraDey-Dev
Remove legacy ClusterTrustBundle RBAC test; add basic traffic test wi…
3d8eee7 
…th CTB enabled

Signed-off-by: Aritra Dey <adey01027@gmail.com>
@AritraDey-Dev
fix string issue
108aa39 
Signed-off-by: Aritra Dey <adey01027@gmail.com>
@AritraDey-Dev AritraDey-Dev added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jun 25, 2025
@AritraDey-Dev
fix lint target
1343cc6 
Signed-off-by: Aritra Dey <adey01027@gmail.com>
@AritraDey-Dev
fix path of tests file
50602e5 
Signed-off-by: Aritra Dey <adey01027@gmail.com>
@istio-testing
Copy link
Collaborator

@AritraDey-Dev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
integ-pilot-istiodremote_istio 50602e5 link true /test integ-pilot-istiodremote
integ-cni_istio 50602e5 link true /test integ-cni
integ-pilot_istio 50602e5 link true /test integ-pilot
integ-pilot-multicluster_istio 50602e5 link true /test integ-pilot-multicluster
integ-pilot-istiodremote-mc_istio 50602e5 link true /test integ-pilot-istiodremote-mc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@zirain
Copy link
Member
zirain commented Jun 26, 2025

you need add a new test suite with flag enabled, here is an example.

@dgn
Copy link
Contributor
dgn commented Jun 26, 2025

HI @AritraDey-Dev, the idea for this issue was to add ClusterTrustBundle support as a feature in istio/enhancements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/security do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add ClusterTrustBundle support to feature table
5 participants
@AritraDey-Dev @zirain @istio-testing @dgn @istio-policy-bot
0