8000 support exclude namespaces for istioctl analyze by my-git9 · Pull Request #56760 · istio/istio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

support exclude namespaces for istioctl analyze #56760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support exclude namespaces for istioctl analyze #56760

wants to merge 1 commit into from

Conversation

my-git9
< 8000 span class="Button-content"> Copy link
Member
@my-git9 my-git9 commented Jun 24, 2025 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:

Fix #55504

Add support exclude namespaces for istioctl analyze

@my-git9 my-git9 requested review from a team as code owners June 24, 2025 10:13
@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-policy-bot istio-policy-bot added area/user experience release-notes-none Indicates a PR that does not require release notes. labels Jun 24, 2025
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 24, 2025
@my-git9 my-git9 removed the release-notes-none Indicates a PR that does not require release notes. label Jun 24, 2025
@my-git9 my-git9 force-pushed the exclude-ns branch 3 times, most recently from 6e34692 to 989a817 Compare June 24, 2025 10:53
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 24, 2025
hanxiaop
hanxiaop requested changes Jun 25, 2025
View reviewed changes
Copy link
Member
@hanxiaop hanxiaop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add both unit tests and integration tests when a new feature is introduced.

pkg/config/analysis/local/istiod_analyze.go
@@ -355,13 +355,22 @@ func (sa *IstiodAnalyzer) GetFiltersByGVK() map[config.GroupVersionKind]kubetype
}
}

func (sa *IstiodAnalyzer) AddRunningKubeSourceWithRevision(c kubelib.Client, revision string, remote bool) {
func (sa *IstiodAnalyzer) AddRunningKubeSourceWithRevision(c kubelib.Client, revision string, remote bool, excludeNamespaces ...string) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only works for the resources in the k8s cluster. If we introduce the new flag, we also need to handle the file-based resources.

@my-git9
support exclude namespaces for istioctl analyze
eeae042 
Signed-off-by: xin.li <xin.li@daocloud.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanxiaop hanxiaop hanxiaop requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area/networking area/user experience size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support exclude namespaces for istioctl analyze
4 participants
@my-git9 @istio-policy-bot @hanxiaop @istio-testing
0