8000 Update client go by zirain · Pull Request #56780 · istio/istio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update client go #56780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 26, 2025
Merged

Update client go #56780

merged 4 commits into from
Jun 26, 2025

Conversation

zirain
Copy link
Member
@zirain zirain commented Jun 26, 2025 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:

fixes: #56770

@istio-policy-bot
Copy link

🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test?

Courtesy of your friendly test nag.

@istio-policy-bot istio-policy-bot added the release-notes-none Indicates a PR that does not require release notes. label Jun 26, 2025
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 26, 2025
zirain
zirain commented Jun 26, 2025
View reviewed changes
pilot/pkg/model/push_context.go
@@ -997,6 +998,9 @@ func (ps *PushContext) extraServicesForProxy(proxy *Proxy, patches *MergedEnvoyF
addService(p.EnvoyTcpAls.Service)
case *meshconfig.MeshConfig_ExtensionProvider_EnvoyOtelAls:
addService(p.EnvoyOtelAls.Service)
case *meshconfig.MeshConfig_ExtensionProvider_Sds:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @ramaraochavali

@istio-testing istio-testing merged commit 4309c90 into istio:master Jun 26, 2025
30 checks passed
@zirain zirain deleted the update-client-go branch June 26, 2025 04:57
@zirain zirain restored the update-client-go branch June 26, 2025 05:42
@zirain zirain deleted the update-client-go branch June 26, 2025 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

@costinm costinm Awaiting requested review from costinm costinm is a code owner

@linsun linsun Awaiting requested review from linsun linsun is a code owner

@stevenctl stevenctl Awaiting requested review from stevenctl stevenctl is a code owner

@keithmattix keithmattix Awaiting requested review from keithmattix keithmattix is a code owner

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu hzxuzhonghu is a code owner

Assignees
No one assigned
Labels
release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zirain @istio-policy-bot @howardjohn @istio-testing
0