8000 Add annotation support to deployment object in istio discovery chart by ramalabeysekera · Pull Request #56787 · istio/istio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add annotation support to deployment object in istio discovery chart #56787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add annotation support to deployment object in istio discovery chart #56787

wants to merge 3 commits into from
+20 −0

Conversation

ramalabeysekera
Copy link
@ramalabeysekera ramalabeysekera commented Jun 26, 2025 •
edited
Loading

Summary

This PR adds support for deploymentAnnotations in the istiod Helm chart, allowing users to add custom annotations to the istiod Deployment object. Previously, the chart only supported pod-level annotations via podAnnotations.

Motivation

There are cases where deployment-level annotations are needed: some agents like Cortex read annotations from Deployment objects rather than individual pods

Changes Made

Template Changes (manifests/charts/istio-control/istio-discovery/templates/deployment.yaml)

  • Added conditional block to include deployment annotations when deploymentAnnotations is defined in values
  • Uses toYaml function with proper indentation to maintain YAML structure

Values Changes (manifests/charts/istio-control/istio-discovery/values.yaml)

  • Added deploymentAnnotations: {} field

Usage Example

Users can now specify deployment annotations in their values:

deploymentAnnotations:
  example.com/owner: "platform-team"
  cortex.io/tag: "istiod"

This will result in annotations being applied to the istiod Deployment object:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: istiod
  annotations:
    example.com/owner: "platform-team"
    cortex.io/tag: "istiod"

Testing

  • Verified Helm template renders correctly with deploymentAnnotations set
  • Verified template renders correctly with empty deploymentAnnotations (default behavior unchanged)
  • Confirmed no impact on existing pod annotations functionality
  • Validated YAML structure and indentation

@ramalabeysekera ramalabeysekera requested a review from a team as a code owner June 26, 2025 10:32
@istio-policy-bot
Copy link

😊 Welcome @ramalabeysekera! This is either your first contribution to the Istio istio repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Jun 26, 2025
@istio-testing
Copy link
Collaborator

Hi @ramalabeysekera. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jacob-delgado
Copy link
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jun 27, 2025
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ramalabeysekera @istio-policy-bot @istio-testing @jacob-delgado
0