8000 feat: represent revision tags using services by german1608 · Pull Request #56141 · istio/istio · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: represent revision tags using services #56141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Jun 26, 2025
Merged

feat: represent revision tags using services #56141

merged 37 commits into from
Jun 26, 2025

Conversation

german1608
Copy link
Contributor
@german1608 german1608 commented Apr 30, 2025 •
edited by istio-policy-bot
Loading

Please provide a description of this PR:

This PR implements clusterip services as a replacement for mutatingwebhooks when using revision tags.

Design doc: https://docs.google.com/document/d/1gCvcTUo0f5HhOZ5UFHYK_moDGXVAZTssZBPhPvewqGU/edit?tab=t.0

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Apr 30, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link
linux-foundation-easycla bot commented Apr 30, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@istio-policy-bot
Copy link

😊 Welcome @german1608! This is either your first contribution to the Istio istio repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-ok-to-test labels Apr 30, 2025
@istio-testing
Copy link
Collaborator

Hi @german1608. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@german1608 german1608 force-pushed the feat/use-services-for-mwh-replacement branch from 3a29e28 to a5bc155 Compare April 30, 2025 21:39
@Stevenjin8
Copy link
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels May 6, 2025
@german1608
Copy link
Contributor Author

/ok-to-test

1 similar comment
@german1608
Copy link
Contributor Author

/ok-to-test

@german1608
Copy link
Contributor Author

/retest

@german1608 german1608 force-pushed the feat/use-services-for-mwh-replacement branch from 1eb3fea to 759a032 Compare May 13, 2025 18:00
@german1608
Copy link
Contributor Author

/ok-to-test

5 similar comments
@german1608
Copy link
Contributor Author

/ok-to-test

@german1608
Copy link
Contributor Author

/ok-to-test

@german1608
Copy link
Contributor Author

/ok-to-test

@german1608
Copy link
Contributor Author

/ok-to-test

@german1608
Copy link
Contributor Author

/ok-to-test

@german1608
Copy link
Contributor Author

/retest

@german1608 german1608 changed the title Feat/use services for mwh replacement feat: represent revision tags using services May 15, 2025
@german1608 german1608 marked this pull request as ready for review May 15, 2025 17:54
@german1608 german1608 requested review from a team as code owners May 15, 2025 17:54
german1608 added 23 commits June 24, 2025 17:08
@german1608
add uniqTagsFromServices and uniqTagsFromWebhooks
bc07b99
@german1608
istioctl tag list consider services
a110ce1
8000
@german1608
add operatorManageWebhooks guard to revision-tags-mwc.yaml
24e997a
@german1608
rename revision-tags.yaml to revision-tags-svc.yaml
073cd3b
@german1608
refactor delete test case
daf14e4
@german1608
test istioctl tag list
cf5d4a0
@german1608
remove ambient check, create and manage both resources at the same time
5032ff8
@german1608
wip test cases
7355e44
@german1608
remove controlplane mode
d363126
@german1608
fix test
a9b0c57
@german1608
my own code review
31951ca
@german1608
fix compilation error
d523a99
@german1608
fix lint
ee5c292
@german1608
wip integ-helm_istio
d60799b
@german1608
add app=istiod label filter
b9a7b34
@german1608
merge override labels in generate.go
0b0537e
@german1608
add release note
21c8037
@german1608
set owner labels to revision service tag
97ff49e
@german1608
rollback changes on e2e for helm
4a40763
@german1608
fix helm e2e
177ac99
6D40
@german1608
use servicesAfters instead of webhooksAfter in tag_test.go assertion log
6588467
@german1608
Remove unnecessary deprecation message
245dfac
@german1608
refactor tag_test.go to reduce diff size
c40ad5a
@german1608 german1608 force-pushed the feat/use-services-for-mwh-replacement branch from 3608262 to c40ad5a Compare June 24, 2025 17:10
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Jun 24, 2025
@german1608 german1608 requested a review from howardjohn June 24, 2025 21:02
@german1608
Copy link
Contributor Author

@howardjohn could you take a look at this PR please? Let me know any outstanding questions

@istio-testing istio-testing merged commit 0550a31 into istio:master Jun 26, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhawton dhawton dhawton left review comments

Copilot code review Copilot Copilot left review comments

@howardjohn howardjohn howardjohn approved these changes

@therealmitchconnors therealmitchconnors therealmitchconnors approved these changes

Assignees
No one assigned
Labels
area/ambient Issues related to ambient mesh area/environments area/user experience ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@german1608 @istio-policy-bot @istio-testing @Stevenjin8 @therealmitchconnors @howardjohn @dhawton
0