8000 nftables: Install nft binary in CI base image for testing by yxun · Pull Request #3209 · istio/tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

nftables: Install nft binary in CI base image for testing #3209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

nftables: Install nft binary in CI base image for testing #3209

merged 1 commit into from
May 20, 2025

Conversation

yxun
Copy link
Contributor
@yxun yxun commented May 19, 2025 •
edited
Loading

Hello, this change is related to istio/istio#47821

We'd like to have the nft binary installed in the gcr.io/istio-testing/base and gcr.io/istio-release/base base images. And then we can build istio images such as proxyv2 with nftables alternative tool and commands for traffic redirection.

Is there any change I also need from the istio/release-builder repo ? Thanks,

@yxun
Install nft binary in base image
4e1e672 
Signed-off-by: Yuanlin Xu <yuanlin.xu@redhat.com>
@yxun yxun requested a review from a team as a code owner May 19, 2025 18:45
@istio-policy-bot
Copy link

😊 Welcome @yxun! This is either your first contribution to the Istio tools repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels May 19, 2025
@istio-testing
Copy link
Contributor

Hi @yxun. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

howardjohn
howardjohn reviewed May 19, 2025
View reviewed changes
Copy link
Member
@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will also need to add it to the distroless image I would imagine.

Given that image is design to be as slim as possible it would be good to post a diff before/after adding it. Note the image is built with apko. You can use crane to dump the contents and compare

howardjohn
howardjohn approved these changes May 19, 2025
View reviewed changes
Copy link
Member
@howardjohn howardjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I misunderstood this. this is just the CI image not used by users. Not sure this is what you meant to change but may be useful for testing so lgtm

@yxun yxun mentioned this pull request May 20, 2025
Open
1 task
@yxun
Copy link
Contributor Author
yxun commented May 20, 2025 •
edited
Loading

we will also need to add it to the distroless image I would imagine.

Given that image is design to be as slim as possible it would be good to post a diff before/after adding it. Note the image is built with apko. You can use crane to dump the contents and compare

Hello, John,
I have created another PR about the base and distroless images in istio/istio#56363
The distroless image content diff is pasted in the PR description.

We'd like to have nftables installed in gcr.io/istio-release/base . And we also want to have nftables installed in CI base image for testing so I created this istio/tools repo PR.
Thanks for your suggestion.

@yxun yxun changed the title nftables: Install nft binary in base image nftables: Install nft binary in CI base image for testing May 20, 20 8000 25
@sridhargaddam
Copy link

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels May 20, 2025
@istio-testing istio-testing merged commit 87674d7 into istio:master May 20, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees
No one assigned
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yxun @istio-policy-bot @istio-testing @sridhargaddam @howardjohn
0