MAINT: stats.UnivariateDistribution: add attribute _discrete #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3b61043 to
f546110
Compare
mdhaber
commented
May 23, 2025
Comment on lines
-3621
to
-3622
| integral = (loc == np.round(loc)) | ||
| loc[~integral] = np.nan |
There was a problem hiding this comment.
If non-integral values are going to result in NaN, we'd want to use the parameter infrastructure to deal with this. This suggests the need for different discrete and continuous shifted/scaled distributions - the continuous ones accept continuous loc/scale parameters, the discrete versions only accept integral ones.
I need to think about exactly how I want to do this, though. I'm not certain there should be se 8000 parate discrete and continuous shifted/scaled classes.
|
Sorry I completely missed the notification for this. I'll take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this solves the immediate problem. There are a few others to work out.
I probably should have used a
_typestring instead of_discreteboolean, but it's OK for now.