10000 #add tagnotify by glukaza · Pull Request #8 · justwatchcom/github-releases-notifier · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

#add tagnotify #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agr 8000 ee to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

#add tagnotify #8

wants to merge 4 commits into from

Conversation

glukaza
Copy link
@glukaza glukaza commented Sep 28, 2018

Notification about new not release tags (some repositories doesn't use "releases")

@metalmatze
Copy link
Collaborator

Thanks you for sending this PR. Something like that would really be helpful.

Please note, that the current state of this project only saves its state in memory and I (personally) would like to avoid having Redis as dependency. I don't see a problem why the new functionality shouldn't be possible without Redis.

Please also run go fmt on all modified files.

Thanks!

@glukaza
Copy link
Author
glukaza commented Sep 28, 2018

Thakyou for feedback!
Entity Tag in github doesn't have field "date" or other fields by which we can make out new release because we need save state, it is bad of course.
If I save state in memory, after next restart we will get notifies about all repositories.

@metalmatze
Copy link
Collaborator

Yup. I think it's exactly the same with the current implementation for official github releases.
We simply get everything the first time and only then start notifying if something changes (but it's been a while and I might have to look at the code again).

@glukaza
Copy link
Author
glukaza commented Sep 28, 2018

In case with "Releases" you work with publish_at field
but entity tag dosent have it, for example: https://api.github.com/repos/keycloak/keycloak/tags

I can change redis for something other, but without state behavior will be strange

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glukaza @metalmatze @VeeamAlexD
0