8000 fix(analytics): Umami tracking pageviews properly by cromelex · Pull Request #1967 · jackyzha0/quartz · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix(analytics): Umami tracking pageviews properly #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2025
Merged

fix(analytics): Umami tracking pageviews properly #1967

merged 1 commit into from
May 7, 2025

Conversation

cromelex
Copy link
Contributor
@cromelex cromelex commented May 7, 2025

Update componentResources.ts to fix umami analytics when SPA is enabled in Quartz.

Closes #1966

@cromelex
Update componentResources.ts to fix umami SPA tracking
bd452dd 
Update componentResources.ts to fix umami analytics when SPA is enabled in Quartz
@github-actions GitHub Actions
Copy link
github-actions bot commented May 7, 2025 •
edited
Loading
built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
quartz ✅ Ready (View Log) Visit Preview bd452dd

@saberzero1
Copy link
Collaborator

Hey, just as a sanity check: does this change impact tracking when enableSPA: false is set?

@cromelex
Copy link
Contributor Author
cromelex commented May 7, 2025

Hey, just as a sanity check: does this change impact tracking when enableSPA: false is set?

It does not impact. When enableSPA: false is set, the tracking/analytics still work as they did previously.

I tested earlier but just re-tested now.
Umami provides the same data points with enableSPA: false as it did before this change.

With the PR there is no difference in the umami analytics between enableSPA: false and enableSPA: true.

Screenshot_20250507-201204

saberzero1
saberzero1 approved these changes May 7, 2025
View reviewed changes
Copy link
Collaborator
@saberzero1 saberzero1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for verifying.

@saberzero1 saberzero1 changed the title Update componentResources.ts to fix umami SPA tracking fix(analytics): Umami tracking pageview properly May 7, 2025
@saberzero1 saberzero1 changed the title fix(analytics): Umami tracking pageview properly fix(analytics): Umami tracking pageviews properly May 7, 2025
@saberzero1 saberzero1 merged commit 59d4b4e into jackyzha0:v4 May 7, 2025
6 checks passed
LouisJalouzot pushed a commit to LouisJalouzot/louisjalouzot.github.io that referenced this pull request May 11, 2025
@cromelex
fix(analytics): Umami tracking pageviews properly
aa87645 
Update componentResources.ts to fix umami SPA tracking (jackyzha0#1967)

Update componentResources.ts to fix umami analytics when SPA is enabled in Quartz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saberzero1 saberzero1 saberzero1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Umami analytics page tracking not working properly when enableSPA is true
2 participants
@cromelex @saberzero1
0