fix(flex): respect DesktopOnly and MobileOnly components #1971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Flex component’s CSS issues by ensuring that DesktopOnly and MobileOnly elements receive the correct display properties regardless of their containment inside the Flex component.
- Added a reusable .flex-component CSS class in base.scss with support for desktop-only and mobile-only variants.
- Modified the Flex component in Flex.tsx to remove the inline display property and use the new CSS class instead.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| quartz/styles/base.scss | Added .flex-component styling and nested rules for desktop/mobile-only responsiveness. |
| quartz/components/Flex.tsx | Removed inline display declaration and added class aggregation for flex-component styling. |
Comments suppressed due to low confidence (1)
quartz/styles/base.scss:131
- [nitpick] Consider adding a brief comment explaining the reasoning behind the nested &.flex-component rules to improve maintainability and clarity regarding the CSS specificity, especially under media queries.
&.flex-component { display: flex; }
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the Flex component so that the CSS rules for desktop-only and mobile-only components work correctly by adding a "flex-component" class and updating the related styles.
- Updated base.scss to add a new "flex-component" class and adjust media query rules.
- Modified Flex.tsx to apply the "flex-component" class to the Flex container.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| quartz/styles/base.scss | Added .flex-component rules and updated desktop-only/mobile-only styles with media query adjustments |
| quartz/components/Flex.tsx | Updated Flex component to use classNames for proper CSS class application |
|
let's also add a notes into Flex component docs here. |
This is in line with Obsidian's behavior.
…ferently (#1992) * feat: add option to disable broken wikilinks * fix(style): update hover color for broken links and introduce new class * feat: add "disableBrokenWikilinks" option to ObsidianFlavoredMarkdown
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…y with 9 updates (#1996) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1969
Cause
The inline
stylein theFlexcomponent was overriding any otherdisplayCSS value set to it. In addition,desktop-onlyandmobile-onlywere only applied to components inside theFlexcomponent.This change adds a
flex-componentCSS class to theFlexcomponent, as well as anydesktop-onlyormobile-onlyclass, if applicable. The CSS rules fordesktop-onlyandmobile-onlyhave been extended to setdisplay: flexinstead ofdisplay: initialwhen used withdesktop-onlyormobile-only.