Testing tools #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Used to test all response helpers.
This allows for simpler, concurrent testing.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces testing utilities for tool modules, updates JSON response formatting in the core Vancouver.Tool, and modifies the router/dispatch pipeline to pass tool lists via assigns.
- Add ExUnit tests for
TestResponseandCalculateSumtools and shared test helpers inToolTest - Change all
send_*functions inVancouver.Toolto emit string keys for JSON compatibility - Update router to use
copy_opts_to_assignand read tool list fromconn.assigns
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/vancouver/tools/test_response_test.exs | Add tests for Vancouver.Tools.TestResponse responses |
| test/vancouver/tools/calculate_sum_test.exs | Add basic test for Vancouver.Tools.CalculateSum running sum logic |
| test/vancouver/test/tool_test.exs | Add shared helper functions and assertions for tool call and outputs |
| lib/vancouver/tools/test_response.ex | Implement TestResponse tool with various response types |
| lib/vancouver/tool.ex | Change JSON payload keys from atoms to strings in all send_* funcs |
| lib/vancouver/router.ex | Use copy_opts_to_assign for passing router opts and compact DSL |
| lib/vancouver/plugs/pipeline.ex | Minor formatting tweak in pipeline builder |
| lib/vancouver/plugs/dispatch.ex | Read tool list from conn.assigns instead of application env |
| README.md | Update config and routing example to pass tools via forward |
Comments suppressed due to low confidence (2)
test/vancouver/test/tool_test.exs:1
- [nitpick] The test module is named
Vancouver.Test.ToolTestbut the implementation module isVancouver.ToolTest; consider renaming the test module (and its path) toVancouver.ToolTestfor consistency.
defmodule Vancouver.Test.ToolTest do
test/vancouver/tools/test_response_test.exs:48
- The test uses
JSON.encode!but there's no alias or import forJSON; addalias JSONor use the proper JSON module (e.g.,Jason) to avoid undefined module errors.
|> conn("/", JSON.encode!(body))
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several enhancements and refactors to the Vancouver library, focusing on improving tool configuration, response handling, and test coverage. Key changes include dynamic tool assignment, updates to response structures, and the addition of comprehensive test modules for tools and their responses.
Tool Configuration and Routing Updates:
config.exandrouter.exto allow dynamic tool assignment via thetoolsoption, enabling more flexible routing configurations (README.md,lib/vancouver/router.ex). [1] [2]Vancouver.Plugs.Dispatchto retrieve tools fromconn.assignsinstead of application environment, improving request-specific tool handling (lib/vancouver/plugs/dispatch.ex).Response Structure Refactors:
Vancouver.Toolto use string keys instead of atom keys for JSON compatibility (lib/vancouver/tool.ex). [1] [2] [3] [4]New Tool and Testing Utilities:
Vancouver.Tools.TestResponse, a tool for testing various response types such as audio, text, image, and error responses (lib/vancouver/tools/test_response.ex).Vancouver.ToolTest, a utility module providing helper functions for testing tool responses (lib/vancouver/test/tool_test.ex).Test Suite Enhancements:
TestResponseandCalculateSumtools, ensuring correctness of tool responses under various scenarios (test/vancouver/tools/test_response_test.exs,test/vancouver/tools/calculate_sum_test.exs). [1] [2]Vancouver.ToolTestutilities to validate their behavior and error handling (test/vancouver/test/tool_test.exs).These changes collectively improve the flexibility, reliability, and testability of the Vancouver library.