Add PromptTest #14
Merged
Add PromptTest #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a Vancouver.PromptTest helper module for testing JSON-RPC prompt responses (audio, image, text) and a corresponding Vancouver.Test.PromptTest suite to verify its behavior.
- Introduce
Vancouver.PromptTestwith functions:audio_response/1,image_response/1,text_response/1,build_request/2, andget_role/1. - Add
Vancouver.Test.PromptTesttests covering valid and invalid scenarios for each utility. - Provide
build_success_conn/2helper in tests to simulate successful JSON-RPC responses.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/vancouver/test/prompt_test.ex | Implemented test utilities for parsing and validating responses |
| test/vancouver/test/prompt_test.exs | Added unit tests for each utility and a helper to build test conns |
Comments suppressed due to low confidence (5)
test/vancouver/test/prompt_test.exs:10
- The
describeblock referencesbuild_request/3but the function signature isbuild_request/2. Please update the description to/2.
describe "build_request/3" do
lib/vancouver/test/prompt_test.ex:16
- The spec indicates an atom-keyed map, but the function returns a string-keyed map (e.g.,
%{"data" => ..., "mimeType" => ...}). Update the spec to reflect amap()or the correct key types.
@spec audio_response(Plug.Conn.t()) :: %{data: String.t(), mimeType: String.t()}
lib/vancouver/test/prompt_test.ex:18
- The
JSONmodule isn't aliased or imported; this will cause a compile error. Consider aliasing your JSON library (e.g.,alias Jason) or replacingJSON.decode!with the proper module (e.g.,Jason.decode!).
response = JSON.decode!(conn.resp_body)
test/vancouver/test/prompt_test.exs:158
- The
JSONmodule isn't available in the test; you need to alias your JSON encoder (e.g.,alias Jason) or call the correct module (e.g.,Jason.encode!).
|> Map.put(:resp_body, JSON.encode!(body))
lib/vancouver/test/prompt_test.ex:33
- The module path (
lib/vancouver/test/prompt_test.ex) doesn’t align with the module namespaceVancouver.PromptTest. Consider moving the file tolib/vancouver/prompt_test.exto match Elixir conventions.
@spec build_request(String.t(), map()) :: map()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new module,
Vancouver.PromptTest, to provide utility functions for testing prompts, along with a comprehensive test suite inVancouver.Test.PromptTestto validate these utilities. The changes aim to streamline the testing of responses for different content types (audio, image, text) and ensure robust handling of various scenarios.New Testing Utilities:
Vancouver.PromptTestmodule with functions to process and validate responses (audio_response/1,image_response/1,text_response/1), build request bodies (build_request/2), and extract roles (get_role/1). These utilities simplify testing by encapsulating common logic.Test Suite for Utilities:
Vancouver.Test.PromptTestwith unit tests for each utility function:audio_response/1,image_response/1, andtext_response/1with valid and invalid inputs.build_request/2to ensure it generates properly formatted request payloads.