8000 Move style_dict from Mesh to Shader and add UniformShader by janbridley · Pull Request #17 · janbridley/svg3d · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Move style_dict from Mesh to Shader and add UniformShader #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jun 11, 2025
Merged

Move style_dict from Mesh to Shader and add UniformShader #17

merged 16 commits into from
Jun 11, 2025

Conversation

janbridley
Copy link
Owner
@janbridley janbridley commented Jun 10, 2025 •
edited
Loading

The Mesh class has been changed to hold no style or color information. Instead, a Shader attached to the mesh contains this information. To reproduce the old behavior, attach a UniformShader with the desired color.

Description

Motivation and Context

Checklist:

  • The changes introduced by this pull request are covered by existing or newly introduced tests.
  • I have updated the changelog.

📚 Documentation preview 📚: https://svg3d--17.org.readthedocs.build/en/17/

@janbridley janbridley marked this pull request as ready for review June 11, 2025 15:49
@janbridley janbridley merged commit 868040d into main Jun 11, 2025
10 checks passed
@janbridley janbridley deleted the change/remove-style-from-mesh branch June 11, 2025 15:49
Sign up for free to join this conversation on GitHub. Al 5647 ready have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janbridley
0