8000 Fixed property validator overwriting by MyZik · Pull Request #758 · janephp/janephp · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fixed property validator overwriting #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom 8000
Merged
merged 3 commits into from
Nov 20, 2023
Merged

Fixed property validator overwriting #758

merged 3 commits into from
Nov 20, 2023

Conversation

MyZik
Copy link
@MyZik MyZik commented Oct 2, 2023

Resolves #736

@MyZik
Copy link
Author
MyZik commented Nov 15, 2023 •
edited
Loading

Hello @Korbeil ,

we would like to integrate this pull request because without these changes, we cannot generate the correct clients. Could you please review the PR and, if necessary, tag and integrate it?

Best regards

Korbeil
Korbeil approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member
@Korbeil Korbeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Could you add a note about your change in the CHANGELOG please ?

@Korbeil
Copy link
Member
Korbeil commented Nov 20, 2023

Thanks for the contribution @MyZik 👍

@Korbeil Korbeil merged commit 2a17883 into janephp:next Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Korbeil Korbeil Korbeil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

$ref validator constraints overwrited by next property
3 participants
@MyZik @Korbeil @eg-check24
0