Filter by app names #56
Conversation
|
Damn, I had not thought about that! Maybe letting the user search for |
|
I bet !"two words" is fine for now, but ideally we'd have a separate sql table of unique application names that we could retrieve from and have a dropdown filter |
|
I added a dropdown filter next to the search bar and reverted the changes to search with The apps shown in the menu are updated according to the user's data, meaning that if the user opens a new app, it will be added to the menu, and if the user deletes all their data, the menu will only show "All apps". rem.picker.demo.mov |
There was a problem hiding this comment.
I'll approve as this is great and immediately useful, but I would use the suggested approach of a table for unique application names. The current approach needs to do a full scan and that will get slower and slower as users record more and more.
You'd want the code you have anyway as there will need to be a check, "if unique application names table doesn't exist seed it with distinct application names".
The other question I'd ask is how much effort a searchable drop-down would be? Users could easily have hundreds of apps.
Regardless both can be future work.
|
On second pass, when does getAppFilterData get called? Only on initial creation? If I close search and use a new app and reopen it, will it show up? |
|
Yes. If you close search, open a new app and search for it again, it will show up. I am working on the new database table for unique app names. I am testing it and will push the code soon. I hope it addresses the possible performance issues. |
|
Awesome - happy to merge this as is, and you can open a second pr! |
|
Before you merge: I noticed that after stopping the first screen recording and starting a new one, the new frames only show up after searching for something. Do you know if this is something that had already been happening before? |
|
When you open search / timeline it pauses the recording and processes what it's seen so far. It might be the case that we aren't calling the retrieve results again automatically when new frames come in and/or not showing frames that don't yet have a thumbnail. Either case I don't think you introduced the behavior. But if you want to confirm, you can try on main branch! |
|
@caetano-dev want me to merge this first, then #62 ? Both are looking good! |
|
Sure, you can do that! |
|
Please, also try to test the changes in your machine before merging with the main branch. It is working for me, but the more people test it, the better. When testing #62, maybe you will need to purge the data to ensure the new table is created. |
|
Couple of small tweaks to make proper spacing for the search, and added a border for better visibility. I'll add them after merging! |
This pull request adds a feature that lets the user choose a given app to search by adding a
!<name>prefix.