8000 Feat:added login item - Rem will run on boot by ruslanjabari · Pull Request #9 · jasonjmcghee/rem · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Feat:added login item - Rem will run on boot #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 3, 2024

Conversation

ruslanjabari
Copy link
Contributor

added https://github.com/sindresorhus/LaunchAtLogin-Modern

note: used the version that works on macOS 13.0+ since the min deployment target for the project is 14.0

@jasonjmcghee
Copy link
Owner

Thought a lot about this one. I think rem isn't stable enough to warrant this as a feature yet.

Maybe I'm overthinking it?

I remember when I tried out the first version of rewind released, it literally would not close. I'd try closing it, and a few minutes later it would reopen. I genuinely never figured it out until i completely uninstalled it.

I'm concerned about something like that happening if it's not entirely user controlled at this very unstable state.

@djsavvy
Copy link
djsavvy commented Jan 21, 2024

For what it's worth, I've set up rem to auto-launch on login by manually adding it to my login items, and I haven't had any issues so far.

However, it doesn't start auto-remembering this way — I still have to manually toggle "start remembering".

@Dbz
Copy link
Dbz commented Mar 3, 2024

I am also interested in this feature

@jasonjmcghee
Copy link
Owner

Hi @ruslanjabari - I know it's been a few months, but I think things are stable enough that it's the right time to merge this. I integrated your code into our settings manager, and seems to work as it's supposed to in my testing.

I'm going to merge it!

@jasonjmcghee jasonjmcghee merged commit 9c37dfa into jasonjmcghee:main Mar 3, 2024
@ruslanjabari
Copy link
Contributor Author

Agreed.

@ruslanjabari ruslanjabari deleted the feat/added-login-item branch March 4, 2024 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0