startScreenCapture in loop #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rem/remApp.swift
Outdated
Comment on lines
355
to
357
| Task { | ||
| await startScreenCapture() | ||
| } |
There was a problem hiding this comment.
fwiw this removes the 2 second delay it had before. is this intentional? should the retry happen immediately?
There was a problem hiding this comment.
Good catch! I added a fix and will do some testing
jasonjmcghee
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change retryScreenshot() to retryScreenCapture():
Instead of trying to retake the screenshot with the same shareableContent var, startScreenCapture() is run to ensure proper monitor capturing if a monitor is added or removed after the first call to startScreenCapture().