-
Notifications
You must be signed in to change notification settings - Fork 35
Use stm32f3xx-hal instead of stm32f30x_hal and upgrade all dependencies #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thank you for this! However, this introduces breaking changes for users so the minor version should be bumped instead of the patch version. |
I was going to do it but then I decide to let @japaric to bump it when releasing to crates.io.
|
I just ran into this with #110. I was beginning down the road of making a very similar change when I noticed this. What changes need to be made here to make this ready to go? Is it just the version number? |
|
@Disasm I continued chasing the compiler errors on my branch a bit. It looked like I was going to end up in the same place as this PR. I’m going to pull this branch later and see if it’s still in working condition. |
It builds clean on stable, but some of the dependencies are out of date already. |
I can confirm moving from f3 0.6.0 to this fork seems to produce nothing but Framing errors when I read my serial port. Anything I can do to move this forward? |
Oh, I fixed it as soon as I posted - typical. With the newer crate you have to set up the clocks to use the external oscillator, otherwise the UART doesn't work. I guess I was running at 32 kHz or something. Now I get issues clearing UART errors, but that's a question for the HAL crate. I'd like to see F3 updated with the newer HAL as soon as possible. |
@thejpster I’ve been working on an alternative bsp that is almost at feature parity. |
This locally ignores deprecation warnings for digital::v1 I/Os for making crate and examples build with Rust 1.44. Pull request japaric#109 already moved to another STM32F3 HAL to solve this issue. So this just makes the code compile whitout running into fatal warnings.
All dependencies upgraded to the latest ones and all examples retested