begin work of supporting current resource usage #358
Conversation
990b2cb to
2a67b25
Compare
This patch begins the process of supporting current resource usage information in `ghw`. The first resource we support is memory on Linux systems. Users can use the `ghw.WithCollectUsage(true)` function to instruct `ghw` to gather usage information for the module in question. Alternately, users can use the `GHW_COLLECT_USAGE=1` environs variable. The following shows the effect of the variable: ``` jaypipes@lappie:~/src/github.com/jaypipes/ghw$ go run cmd/ghwc/main.go memory memory (16GB physical, 16GB usable) jaypipes@lappie:~/src/github.com/jaypipes/ghw$ GHW_COLLECT_USAGE=1 go run cmd/ghwc/main.go memory memory (16GB physical, 16GB usable, 9GB used) ``` Issue #357 Signed-off-by: Jay Pipes <jaypipes@gmail.com>
There was a problem hiding this comment.
At glance, looks fine. The one and only reservation I have is that I'm not a fan of optional fields which are filled only if a global flag is set. I think we could have a couple or more of these fields in the various subsystems.
I'd consider an approach on which we add current resource usage in a more isolated way with respect the current return value. A very quick proposal could be to wrap the resource usage in substructs.
I'll have a proper review shortly in few days time tops.
@ffromani Hi! :) Yeah, I had a similar thought and actually originally I had an approach where I had a separate For things like memory usage, we will always need to determine the structure (NUMA topology) of the system itself and then add usage per NUMA node (on Linux via |
|
@ffromani we could also consider collecting usage information by default and making the collection of usage information disable-able via flag? |
This patch begins the process of supporting current resource usage information in
ghw. The first resource we support is memory on Linux systems.Users can use the
ghw.WithCollectUsage(true)function to instructghwto gather usage information for the module in question. Alternately, users can use theGHW_COLLECT_USAGE=1environs variable. The following shows the effect of the variable:Issue #357