Fix watson config command #161
Conversation
|
We'll need to release a |
There was a problem hiding this comment.
LGTM
I thought I tested that the watson config still works manually, but I've must have messed it up, sorry. I removed this line, because I didn't realize that the setter method for watson.config also sets watson._config_changed and watson.save() only saves the configuration if this attribute is True. So, theoretically, you could also replace this line with watson._config_changed = True (but it would violate encapsulation). I wonder whether it would be better to provide an explicit method on the Watson object to change a single config setting. Or even to get/set the configuration object. Using a property is a bit confusing.
New configuration was never saved on disk.
Follow up of #159 & #158