Use context manager to restore environment variables in resolve() #1255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the event of an unexpected exception, the system's environment variable PIP_EXISTS_ACTION should still be restored to its previous state. This context manager already exists in the upstream pip library. Can reuse it to avoid duplication. Unlike the previous implementation, if the PIP_EXISTS_ACTION environment variable existed prior to executing pip-tools, that state will be restored.
This was referenced Mar 15, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event of an unexpected exception, the system's environment
variable PIP_EXISTS_ACTION should still be restored to its previous
state.
This context manager already exists in the upstream pip library. Can
reuse it to avoid duplication.
Unlike the previous implementation, if the PIP_EXISTS_ACTION environment
variable existed prior to executing pip-tools, that state will be
restored.
Contributor checklist