Remove contextlib.nullcontext compat shim in favor of pip's version #1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1283 +/- ##
=======================================
Coverage 99.65% 99.65%
=======================================
Files 35 35
Lines 2905 2906 +1
Branches 324 324
=======================================
+ Hits 2895 2896 +1
Misses 5 5
Partials 5 5
Continue to review full report at Codecov.
|
atugushev
approved these changes
Jan 1, 2021
This removes the need to maintain yet another compatibility shim that is already handled by pip. pip has a vendored copy of contextlib2, which contains the same copy of the function. At some point in the future, pip-tools can use the stdlib version instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the need to maintain yet another compatibility shim that is
already handled by pip. pip has a vendored copy of contextlib2, which
contains the same copy of the function.
At some point in the future, pip-tools can use the stdlib version
instead.
Contributor checklist