8000 fix: Default alias name when creating a new alias by chrsblck · Pull Request #436 · jbangdev/jbang · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Default alias name when creating a new alias #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 13, 2020
Merged

fix: Default alias name when creating a new alias #436

merged 2 commits into from
Oct 13, 2020

Conversation

chrsblck
Copy link
Contributor

fixes #374

@chrsblck
Copy link
Contributor Author

@quintesse @maxandersen This is ready for review, thanks!

quintesse
quintesse requested changes Oct 13, 2020
View reviewed changes
@chrsblck chrsblck requested a review from quintesse October 13, 2020 18:22
quintesse
quintesse approved these changes Oct 13, 2020
View reviewed changes
Copy link
Contributor
@quintesse quintesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@chrsblck
Copy link
Contributor Author
chrsblck commented Oct 13, 2020 •
edited
Loading

Let me know if you want me to squash the commits, or maybe the GitHub squash and merge is enough

@quintesse
Copy link
Contributor

I'll leave that to @maxandersen , but I think it's okay this way.

@maxandersen maxandersen merged commit f4fa8c5 into jbangdev:master Oct 13, 2020
@maxandersen
Copy link
Collaborator

perfect! thanks @chrsblck !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quintesse quintesse quintesse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

alias add -f directory should create jbang-catalog.json in that directory
3 participants
@chrsblck @quintesse @maxandersen
0