8000 coro:thread_pool use std::thread instead of std::jthread · Issue #220 · jbaldwin/libcoro · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

coro:thread_pool use std::thread instead of std::jthread #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Alread 8000 y on GitHub? Sign in to your account

Jump to bottom
Closed
jbaldwin opened this issue Nov 29, 2023 · 0 comments · Fixed by #221
Closed

coro:thread_pool use std::thread instead of std::jthread #220

jbaldwin opened this issue Nov 29, 2023 · 0 comments · Fixed by #221
Assignees
@jbaldwin

Comments

@jbaldwin
Copy link
Owner

This is in support of using emscripten, since that doesn't support std::jthread yet we'll use std::thread for now.
@jbaldwin jbaldwin self-assigned this Nov 29, 2023
jbaldwin added a commit that referenced this issue Nov 29, 2023
@jbaldwin
Use std::thread for coro::thread_pool
9cdbb8a 
* This change switches from std::jthread to std::thread for the
  coro::thread_pool
* This change is in support of emscripten support

Closes #220
@jbaldwin jbaldwin mentioned this issue Nov 29, 2023
Merged
jbaldwin added a commit that referenced this issue Dec 1, 2023
@jbaldwin
Use std::thread for coro::thread_pool (#221)
d1be506 
* Use std::thread for coro::thread_pool

* This change switches from std::jthread to std::thread for the
  coro::thread_pool
* This change is in support of emscripten support
* The thread pool executors will now drain the queue before re-entering the condition variable.

Closes #220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbaldwin jbaldwin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use std::thread for coro::thread_pool jbaldwin/libcoro
1 participant
@jbaldwin
0